Skip to content

fix(26141): String type autocomplete doesn't work with paren #39697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #26141

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jul 22, 2020
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it work to use skipParentheses instead of recursion?
Also I don't understand why ImportType and UnionType need to return undefined for non-string-literals.

@sandersn sandersn self-assigned this Sep 3, 2020
@a-tarasyuk a-tarasyuk closed this Sep 4, 2020
@sandersn sandersn merged commit 8384018 into microsoft:master Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

String type autocomplete doesn't work with paren
4 participants