Skip to content

🤖 User test baselines have changed for refs/heads/master #39502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

typescript-bot
Copy link
Collaborator

This test run was triggerd by a request on #33716
Please review the diff and merge if no changes are unexpected.
You can view the build log here.

cc @microsoft/typescript

@typescript-bot typescript-bot force-pushed the user-baseline-updates branch from 2ef8400 to b8786ea Compare July 8, 2020 16:19
@typescript-bot typescript-bot mentioned this pull request Jul 8, 2020
@typescript-bot typescript-bot force-pushed the user-baseline-updates branch 28 times, most recently from 88deee1 to b59e09a Compare July 14, 2020 01:25
@typescript-bot typescript-bot force-pushed the user-baseline-updates branch 24 times, most recently from 2c0fd09 to 03e104d Compare July 30, 2020 22:35
@typescript-bot typescript-bot force-pushed the user-baseline-updates branch from 03e104d to 8444833 Compare July 31, 2020 04:35
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to find out why arity check got less strict

@@ -1,9 +1,6 @@
Exit Code: 2
Standard output:
node_modules/uglify-js/lib/ast.js(97,35): error TS2554: Expected 2 arguments, but got 1.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why our arity checking is less strict than 3.9. Did we get more consistent about arity when noImplicitAny is false.

node_modules/uglify-js/lib/compress.js(557,41): error TS2554: Expected 0 arguments, but got 1.
node_modules/uglify-js/lib/compress.js(694,27): error TS2339: Property 'name' does not exist on type '(Anonymous function)'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better typing of this, and uglify uses their own inheritance system. I can't tell if these errors are in functions that intended to be methods, or constructor functions.

node_modules/npmlog/log.js(149,8): error TS2551: Property '_paused' does not exist on type 'typeof EventEmitter'. Did you mean 'pause'?
node_modules/npmlog/log.js(154,13): error TS2551: Property '_paused' does not exist on type 'typeof EventEmitter'. Did you mean 'pause'?
node_modules/npmlog/log.js(155,8): error TS2551: Property '_paused' does not exist on type 'typeof EventEmitter'. Did you mean 'pause'?
node_modules/npmlog/log.js(82,8): error TS2339: Property 'tracker' does not exist on type 'enableProgress'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't understand the "instance method" pattern

var log = new EE()
log.enableProgress = function() {
  this.tracker.on(...)
}

And now with better this typing, we issue an error on 'tracker'.

@@ -1,6 +1,20 @@
Exit Code: 2
Standard output:
node_modules/minimatch/minimatch.js(77,17): error TS2551: Property 'minimatch' does not exist on type 'typeof minimatch'. Did you mean 'Minimatch'?
node_modules/minimatch/minimatch.js(144,12): error TS2339: Property '_made' does not exist on type 'make'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better this typing, and we don't understand the pattern

Minimatch.prototype.make = make
function make() {
  if (this._made) return
}

@@ -306,7 +303,7 @@ node_modules/lodash/findKey.js(41,54): error TS2554: Expected 0-1 arguments, but
node_modules/lodash/findLastIndex.js(56,55): error TS2554: Expected 0-1 arguments, but got 2.
node_modules/lodash/findLastKey.js(41,54): error TS2554: Expected 0-1 arguments, but got 2.
node_modules/lodash/fp.js(2,18): error TS2554: Expected 3-4 arguments, but got 2.
node_modules/lodash/fp/_baseConvert.js(143,5): error TS2559: Type 'Function' has no properties in common with type '{ cap?: boolean; curry?: boolean; fixed?: boolean; immutable?: boolean; rearg?: boolean; }'.
node_modules/lodash/fp/_baseConvert.js(143,5): error TS2559: Type 'Function' has no properties in common with type '{ cap?: boolean | undefined; curry?: boolean | undefined; fixed?: boolean | undefined; immutable?: boolean | undefined; rearg?: boolean | undefined; }'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed nullability of optional parameters when using @param {unknown} [arg] bracket syntax.

node_modules/acorn/acorn-loose/dist/acorn-loose.js(83,12): error TS2339: Property 'next' does not exist on type 'LooseParser'.
node_modules/acorn/acorn-loose/dist/acorn-loose.js(110,16): error TS2339: Property 'lookAhead' does not exist on type 'LooseParser'.
node_modules/acorn/acorn-loose/dist/acorn-loose.js(111,44): error TS2339: Property 'next' does not exist on type 'LooseParser'.
node_modules/acorn/acorn-loose/dist/acorn-loose.js(159,10): error TS2339: Property 'next' does not exist on type 'LooseParser'.
node_modules/acorn/acorn-loose/dist/acorn-loose.js(160,17): error TS2339: Property 'parseTopLevel' does not exist on type 'LooseParser'.
node_modules/acorn/acorn-loose/dist/acorn-loose.js(187,14): error TS2339: Property 'ahead' does not exist on type 'next'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another unrecognised constructor function+method pattern

@@ -10,6 +10,8 @@ node_modules/bluebird/js/release/debuggability.js(301,9): error TS2322: Type 'Pr
node_modules/bluebird/js/release/debuggability.js(301,28): error TS2684: The 'this' context of type '((...args: any[]) => Process) | ((name: any, ...args: any[]) => boolean)' is not assignable to method's 'this' of type '(this: null, args_0?: any, ...args_1: any[]) => Process'.
Type '(name: any, ...args: any[]) => boolean' is not assignable to type '(this: null, args_0?: any, ...args_1: any[]) => Process'.
Type 'boolean' is not assignable to type 'Process'.
node_modules/bluebird/js/release/debuggability.js(456,14): error TS2339: Property '_setBoundTo' does not exist on type 'cancellationPropagateFrom'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Promise.config is assigned a function that contains a whole bunch of non top-level Promise.prototype.method assignments. So we don't treat a bunch of methods as constructor functions, same as the other projects in this PR.

@@ -3393,15 +3461,81 @@ node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(44,23): error T
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(45,23): error TS2365: Operator '>=' cannot be applied to types 'RegExpMatchArray' and 'number'.
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(47,76): error TS2365: Operator '<' cannot be applied to types 'RegExpMatchArray' and 'number'.
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(94,25): error TS2339: Property 'createTextRange' does not exist on type 'HTMLElement'.
node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(306,5): error TS2339: Property 'scrollbarFiller' does not exist on type 'Display'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aliased var d = this defeats this-property assignment detection =(

@@ -11243,6 +11600,24 @@ node_modules/chrome-devtools-frontend/front_end/terminal/xterm.js/build/xterm.js
node_modules/chrome-devtools-frontend/front_end/terminal/xterm.js/build/xterm.js(2721,1): error TS2323: Cannot redeclare exported variable '__esModule'.
node_modules/chrome-devtools-frontend/front_end/terminal/xterm.js/build/xterm.js(2732,1): error TS2323: Cannot redeclare exported variable '__esModule'.
node_modules/chrome-devtools-frontend/front_end/terminal/xterm.js/build/xterm.js(2766,1): error TS2323: Cannot redeclare exported variable '__esModule'.
node_modules/chrome-devtools-frontend/front_end/terminal/xterm.js/build/xterm.js(2789,10): error TS2339: Property 'browser' does not exist on type 'Terminal'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, aliased var self = this

@@ -13065,16 +13440,51 @@ node_modules/chrome-devtools-frontend/front_end/ui/UIUtils.js(1317,27): error TS
node_modules/chrome-devtools-frontend/front_end/ui/UIUtils.js(1318,24): error TS2339: Property '_constructor' does not exist on type 'typeof CheckboxLabel'.
node_modules/chrome-devtools-frontend/front_end/ui/UIUtils.js(1319,74): error TS2339: Property '_constructor' does not exist on type 'typeof CheckboxLabel'.
node_modules/chrome-devtools-frontend/front_end/ui/UIUtils.js(1324,29): error TS2339: Property 'createChild' does not exist on type 'Element'.
node_modules/chrome-devtools-frontend/front_end/ui/UIUtils.js(1334,10): error TS2339: Property 'checkboxElement' does not exist on type 'Element'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're now checking this and the function has an incorrect @this {Element} annotation.

@sandersn
Copy link
Member

The arity check loosening is intentional, and undoes the new errors that arose from constructor functions being real classes, which are instantiated with this types, evading the original no-errors-for-js-signatures exception.

@sandersn sandersn merged commit 1b97d03 into microsoft:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants