Skip to content

Fix crash on completion in jsdoc namepath #39347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

sandersn
Copy link
Member

In completions.ts, contextToken may be undefined, so the isAssertionExpression call in filterGlobalCompletion needs to check for undefined.

Fixes #38407

contextToken may be undefined, so the isAssertionExpression call in
filterGlobalCompletion needs to check for undefined.
@sandersn
Copy link
Member Author

Not sure who's best to review this, so feel free to recommend others.

@sandersn sandersn merged commit df59813 into master Jun 30, 2020
@sandersn sandersn deleted the fix-namepath-completion-crash branch June 30, 2020 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'parent' of undefined at isTypeAssertion
3 participants