Skip to content

Small fix in getIsContextSensitiveAssignmentOrContextType #39053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2020
Merged

Small fix in getIsContextSensitiveAssignmentOrContextType #39053

merged 1 commit into from
Jun 13, 2020

Conversation

elibarzilay
Copy link
Contributor

Test that parentSymbol.valueDeclaration exists.

Fixes #38532

@elibarzilay
Small fix in getIsContextSensitiveAssignmentOrContextType
739eb1b 
Test that `parentSymbol.valueDeclaration` exists.

Fixes microsoft#38532
@elibarzilay elibarzilay requested a review from weswigham June 12, 2020 20:59
@elibarzilay elibarzilay self-assigned this Jun 12, 2020
@elibarzilay
Copy link
Contributor Author

I'm not sure about the name of the test file...

weswigham
weswigham approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the test references the issue it fixes, the name's probably fine enough.

@elibarzilay elibarzilay merged commit 0432954 into microsoft:master Jun 13, 2020
@elibarzilay elibarzilay deleted the 38532 branch June 13, 2020 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

Assignees

@elibarzilay elibarzilay

Labels
Author: Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Naming conflict ends up in unhandled compiler error
3 participants
@elibarzilay @weswigham @typescript-bot