Fixes stack overflow when exporting a lot in commonjs #38994
Merged
+50,123
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you fine folks want to introduce a |
ericanderson
commented
Jun 9, 2020
| statements, | ||
| createExpressionStatement( | ||
| reduceLeft( | ||
| currentModuleInfo.exportedNames!.slice(i, i + chunkSize), |
There was a problem hiding this comment.
.slice() substitutes the length of the array if the second argument is greater than .length
RyanCavanaugh
requested review from
weswigham and
rbuckton
and removed request for
weswigham
weswigham
requested changes
Aug 3, 2020
|
Sorry @weswigham, what do I need to provide besides |
|
|
typescript-bot
added
the
For Milestone Bug
sandersn
approved these changes
Sep 4, 2020
There was a problem hiding this comment.
@DanielRosenwasser we might want to ship this in the next 4.0 patch release. What do you think?
tvh
pushed a commit
to factisresearch/TypeScript
that referenced
this pull request
Oct 9, 2020
* Fixes stack overflow when exporting a lot in commonjs Fixes microsoft#38691 * Add missing test files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38691
I went with the simple solution of not generating long chains of BinaryExpressions rather than introducing a new type similar to
CommaListto avoid large and potentially buggy code churn.Please consider back porting to the next 3.9 release.
CC/ @weswigham @rbuckton @RyanCavanaugh