🤖 User test baselines have changed for refs/heads/master #38917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
typescript-bot
force-pushed
the
user-baseline-updates
branch
27 times, most recently
from
0fd0500 to
95c56d9
Compare
typescript-bot
force-pushed
the
user-baseline-updates
branch
2 times, most recently
from
c6a1156 to
ea6d767
Compare
typescript-bot
force-pushed
the
user-baseline-updates
branch
17 times, most recently
from
09549a8 to
e6482fe
Compare
typescript-bot
force-pushed
the
user-baseline-updates
branch
from
e6482fe to
a3999b4
Compare
sandersn
approved these changes
Jun 15, 2020
| Warning: dist/packages/compiler-core/src/options.d.ts:141:8 - (tsdoc-undefined-tag) The TSDoc tag "@default" is not defined in this configuration | ||
| Warning: dist/packages/compiler-core/src/options.d.ts:146:8 - (tsdoc-undefined-tag) The TSDoc tag "@default" is not defined in this configuration | ||
| Warning: dist/packages/compiler-core/src/options.d.ts:152:8 - (tsdoc-undefined-tag) The TSDoc tag "@default" is not defined in this configuration | ||
| Warning: /vue-next/packages/runtime-dom/src/components/Transition.ts:71:5 - (TS7022) 'name' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer. |
There was a problem hiding this comment.
doesn't repro in the editor; not sure who is pulling on this circularly.
This is from a recent change, vuejs/vue-next#80c868aef, so I'm surprised that it doesn't repro in the local build either. I'll have to do the same local upgrade as the dockerfile and see if it repros.
There was a problem hiding this comment.
build repros with typescript@next
edit: and with the first 4.0 dev branch build. but not 3.9.3...?
edit edit: lol their build is broken.
| @@ -94,7 +94,6 @@ node_modules/async/dist/async.js(622,80): error TS2339: Property 'nodeType' does | |||
| node_modules/async/dist/async.js(748,84): error TS2339: Property 'nodeType' does not exist on type 'NodeModule'. | |||
| node_modules/async/dist/async.js(754,49): error TS2339: Property 'process' does not exist on type 'false | (Global & typeof globalThis)'. | |||
| Property 'process' does not exist on type 'false'. | |||
| node_modules/async/dist/async.js(810,45): error TS2554: Expected 0 arguments, but got 1. | |||
There was a problem hiding this comment.
var isBuffer = nativeIsBuffer || stubFalse used to take any | () => false and reduce to () => false. Not it reduces to any. Seems correct-er-ish.
| @@ -46,8 +46,7 @@ lib/core/enhanceError.js(38,18): error TS2339: Property 'code' does not exist on | |||
| lib/core/settle.js(20,7): error TS2345: Argument of type 'null' is not assignable to parameter of type 'string | undefined'. | |||
| lib/helpers/buildURL.js(22,49): error TS1016: A required parameter cannot follow an optional parameter. | |||
| lib/helpers/cookies.js(16,56): error TS2551: Property 'toGMTString' does not exist on type 'Date'. Did you mean 'toUTCString'? | |||
| lib/utils.js(258,20): error TS8029: JSDoc '@param' tag has name 'obj1', but there is no parameter with that name. It would match 'arguments' if it had an array type. | |||
| lib/utils.js(282,20): error TS8029: JSDoc '@param' tag has name 'obj1', but there is no parameter with that name. It would match 'arguments' if it had an array type. | |||
| lib/utils.js(273,20): error TS8029: JSDoc '@param' tag has name 'obj1', but there is no parameter with that name. It would match 'arguments' if it had an array type. | |||
| @@ -27,6 +27,7 @@ node_modules/debug/dist/debug.js(530,18): error TS2339: Property 'diff' does not | |||
| node_modules/debug/dist/debug.js(531,18): error TS2339: Property 'prev' does not exist on type '{ (...args: any[]): void; namespace: string; enabled: boolean; useColors: any; color: string | number; destroy: () => boolean; extend: (namespace: any, delimiter: any) => Function; }'. | |||
| node_modules/debug/dist/debug.js(532,18): error TS2339: Property 'curr' does not exist on type '{ (...args: any[]): void; namespace: string; enabled: boolean; useColors: any; color: string | number; destroy: () => boolean; extend: (namespace: any, delimiter: any) => Function; }'. | |||
| node_modules/debug/dist/debug.js(563,25): error TS2551: Property 'formatArgs' does not exist on type '{ (namespace: string): Function; debug: ...; default: ...; coerce: (val: any) => any; disable: () => void; enable: (namespaces: string) => void; enabled: (name: string) => boolean; humanize: any; ... 4 more ...; selectColor: (namespace: string) => string | number; }'. Did you mean 'formatters'? | |||
| node_modules/debug/dist/debug.js(564,30): error TS2339: Property 'log' does not exist on type '{ (...args: any[]): void; namespace: string; enabled: boolean; useColors: any; color: string | number; destroy: () => boolean; extend: (namespace: any, delimiter: any) => Function; }'. | |||
There was a problem hiding this comment.
this error was just missing before
| @@ -26,7 +26,6 @@ node_modules/lodash/_arrayIncludes.js(14,34): error TS2345: Argument of type 'an | |||
| node_modules/lodash/_arrayIncludesWith.js(6,15): error TS8024: JSDoc '@param' tag has name 'target', but there is no parameter with that name. | |||
| node_modules/lodash/_arrayIncludesWith.js(10,35): error TS1016: A required parameter cannot follow an optional parameter. | |||
| node_modules/lodash/_arrayIncludesWith.js(15,27): error TS2532: Object is possibly 'undefined'. | |||
| node_modules/lodash/_arrayLikeKeys.js(25,45): error TS2554: Expected 0 arguments, but got 1. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test run was triggerd by a request on #33716
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @microsoft/typescript