Skip to content

fix(38840): Unexpected completions returned for function inside object literal #38897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/services/completions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -956,12 +956,13 @@ namespace ts.Completions {
case SyntaxKind.PropertyAccessExpression:
propertyAccessToConvert = parent as PropertyAccessExpression;
node = propertyAccessToConvert.expression;
if (node.end === contextToken.pos &&
isCallExpression(node) &&
if ((isCallExpression(node) || isFunctionLike(node)) &&
node.end === contextToken.pos &&
node.getChildCount(sourceFile) &&
last(node.getChildren(sourceFile)).kind !== SyntaxKind.CloseParenToken) {
// This is likely dot from incorrectly parsed call expression and user is starting to write spread
// This is likely dot from incorrectly parsed expression and user is starting to write spread
// eg: Math.min(./**/)
// const x = function (./**/) {}
return undefined;
}
break;
Expand Down
33 changes: 33 additions & 0 deletions tests/cases/fourslash/completionWritingSpreadLikeArgument.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
/// <reference path='fourslash.ts'/>

////const t0 = {
//// x: function (./*0*/) {}
////}
////const t1 = {
//// x: (./*1*/) => {}
////}
////const t2 = {
//// x: function foo(./*2*/) => {}
////}
////const t3 = {
//// x(./*3*/) {}
////}
////
////const t4 = function (./*4*/) {}
////const t5 = (./*5*/) => {}
////function t6(./*6*/) {}
////
////class Foo {
//// m(./*7*/) {}
////}

for (const marker of test.markers()) {
goTo.marker(marker);
verify.completions({ exact: undefined });

edit.insert(".");
verify.completions({ exact: undefined });

edit.insert(".");
verify.completions({ exact: undefined });
}