Skip to content

fix(29890): JSX: "extract to constant" generates invalid code #38776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2020

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #29890

@DanielRosenwasser
Copy link
Member

Wonder how this works for JsxText.

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 29, 2020

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 0a83aed. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 29, 2020

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/75182/artifacts?artifactName=tgz&fileId=D9012AF62A68ECA65C1B6214BF8565115DD6B2CA9F8A99AF4573168E675756A402&fileName=/typescript-4.0.0-insiders.20200529.tgz"
    }
}

and then running npm install.


There is also a playground for this build.

@a-tarasyuk
Copy link
Contributor Author

Wonder how this works for JsxText.

@DanielRosenwasser I think QF won't be suggested.

@DanielRosenwasser DanielRosenwasser merged commit 57dd722 into microsoft:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSX: "extract to constant" generates invalid code
3 participants