Skip to content

Intersection check for empty object type shouldn't cause circularities #38673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2020

Conversation

ahejlsberg
Copy link
Member

Fixes #38672.

@DanielRosenwasser
Copy link
Member

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 20, 2020

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 969f9fc. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 20, 2020

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/74426/artifacts?artifactName=tgz&fileId=81732806A56E729623685125BE5B8FABDBAAB7A6BB9D879B7321653A71207DB302&fileName=/typescript-4.0.0-insiders.20200520.tgz"
    }
}

and then running npm install.


There is also a playground for this build.

@ahejlsberg ahejlsberg merged commit a569603 into master May 20, 2020
cangSDARM added a commit to cangSDARM/TypeScript that referenced this pull request May 21, 2020
* upstream/master:
  Make new error an error, not message
  fix(38299): use string literals as keys to creating rest result (microsoft#38600)
  Intersection check for empty object type shouldn't cause circularities (microsoft#38673)
  fix(38682): use stable typescript version (microsoft#38683)
  Add d.ts for Intl.RelativeTimeFormat (microsoft#36084)
  fix(38295): handle duplicate object literal keys which contain '+' and '-' tokens
  make last para of Actomics.notify optional.
  Fix some JSDoc factory function return types.
  fix order and tests
  move to invocationErrorDetails
  replace the original not-callable error
  Add _0_is_declared_here pointing to accessor declaration
  Better error message for accidental calls to get-accessors
sandersn added a commit that referenced this pull request Aug 25, 2020
The dynamic import shim creates a symbol without some properties that
the intersection-creating code assumes are present as of #38673.

This PR adds the smallest possible set of properties to avoid the crash.
I'm not sure what others would be good to add.
sandersn added a commit that referenced this pull request Sep 1, 2020
* Fix crash intersecting dynamic import w/esModuleInterop

The dynamic import shim creates a symbol without some properties that
the intersection-creating code assumes are present as of #38673.

This PR adds the smallest possible set of properties to avoid the crash.
I'm not sure what others would be good to add.

* Use symbol's declarations instead

* Fix getResolvedMembersOrExportsOfSymbol instead

* comment from code review
Titozzz pushed a commit to Brigad/TypeScript that referenced this pull request Sep 7, 2020
)

* Fix crash intersecting dynamic import w/esModuleInterop

The dynamic import shim creates a symbol without some properties that
the intersection-creating code assumes are present as of microsoft#38673.

This PR adds the smallest possible set of properties to avoid the crash.
I'm not sure what others would be good to add.

* Use symbol's declarations instead

* Fix getResolvedMembersOrExportsOfSymbol instead

* comment from code review
@jakebailey jakebailey deleted the fix38672 branch November 7, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circularity error in intersection of object with index signature
4 participants