Skip to content

Have the ChangeTracker filter out edits that are no-ops #38123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 23, 2020
Merged

Have the ChangeTracker filter out edits that are no-ops #38123

merged 6 commits into from
Apr 23, 2020

Conversation

DanielRosenwasser
Copy link
Member

Fixes #22912

sheetalkamat
sheetalkamat reviewed Apr 22, 2020
View reviewed changes
@DanielRosenwasser DanielRosenwasser changed the title Filter out edits that are no-ops in 'organize imports' Have the change-tracker filter out edits that are no-ops Apr 23, 2020
@DanielRosenwasser DanielRosenwasser changed the title Have the change-tracker filter out edits that are no-ops Have the ChangeTracker filter out edits that are no-ops Apr 23, 2020
amcasey
amcasey approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm kind of embarrassed by how simple this turned out to be.

LGTM, except for my perf comment.

sheetalkamat
sheetalkamat reviewed Apr 23, 2020
View reviewed changes
@DanielRosenwasser
Copy link
Member Author

Honestly, this is a great practice in premature optimization, but I feel better knowing it's not much worse off. Summary:

  • There's a fast path for pure additions, deletions, other general differences - those are always kept.
  • When we need to check the contents, we don't allocate or traverse the whole file.
  • We don't allocate ChangeRanges for non-applicable changes or for files if they're empty or useless.

@DanielRosenwasser DanielRosenwasser merged commit d7e437a into master Apr 23, 2020
@DanielRosenwasser DanielRosenwasser deleted the returnNoEditsForNoOps branch April 23, 2020 19:54
@DanielRosenwasser DanielRosenwasser mentioned this pull request Jul 30, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amcasey amcasey amcasey approved these changes

@sheetalkamat sheetalkamat sheetalkamat approved these changes

@elibarzilay elibarzilay Awaiting requested review from elibarzilay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Organize imports always returns an edit, even when imports are already sorted
3 participants
@DanielRosenwasser @sheetalkamat @amcasey