Skip to content

Report error when cannot read file #37611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2020
Merged

Report error when cannot read file #37611

merged 1 commit into from
Mar 26, 2020

Conversation

sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented Mar 25, 2020 •
edited
Loading

This also consolidates helper for readFile failure
Sequel to #37563

@sheetalkamat
Report error when cannot read file
135214a 
This also consolidates helper for readFile failure
@sheetalkamat sheetalkamat mentioned this pull request Mar 25, 2020
Merged
amcasey
amcasey approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sheetalkamat sheetalkamat merged commit 0ae938b into master Mar 26, 2020
@sheetalkamat sheetalkamat deleted the jsonReadFail branch March 26, 2020 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amcasey amcasey amcasey approved these changes

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees

@sheetalkamat sheetalkamat

@amcasey amcasey

Labels
Author: Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sheetalkamat @amcasey @typescript-bot