Skip to content

🤖 User test baselines have changed for refs/heads/master #37498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2020
Merged

🤖 User test baselines have changed for refs/heads/master #37498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
152 changes: 121 additions & 31 deletions tests/baselines/reference/docker/office-ui-fabric.log
View file
Open in desktop

Large diffs are not rendered by default.

54 changes: 27 additions & 27 deletions tests/baselines/reference/docker/vscode.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,39 +4,39 @@ yarn run vX.X.X
$ gulp compile --max_old_space_size=4095
[XX:XX:XX] Node flags detected: --max_old_space_size=4095
[XX:XX:XX] Using gulpfile /vscode/gulpfile.js
[XX:XX:XX] Error: /vscode/src/vs/workbench/electron-browser/parts/titlebar/titlebarPart.ts(222,5): Type 'null' is not assignable to type 'string'.
[XX:XX:XX] Error: /vscode/src/vs/workbench/electron-browser/parts/titlebar/titlebarPart.ts(225,7): Type 'null' is not assignable to type 'string'.
[XX:XX:XX] Error: /vscode/src/vs/workbench/electron-browser/parts/titlebar/titlebarPart.ts(229,7): Type 'null' is not assignable to type 'string'.
[XX:XX:XX] Error: /vscode/src/vs/workbench/contrib/search/common/searchModel.ts(609,21): Type 'FileMatch | FileMatch[]' must have a '[Symbol.iterator]()' method that returns an iterator.
[XX:XX:XX] Error: /vscode/src/vs/workbench/browser/parts/titlebar/titlebarPart.ts(470,5): Type 'null' is not assignable to type 'string'.
[XX:XX:XX] Error: /vscode/src/vs/base/parts/quickinput/browser/quickInputList.ts(474,3): Type '"none" | null' is not assignable to type 'string'.
Type 'null' is not assignable to type 'string'.
[XX:XX:XX] Error: /vscode/src/vs/base/browser/ui/splitview/splitview.ts(113,3): Type '"none" | null' is not assignable to type 'string'.
Type 'null' is not assignable to type 'string'.
[XX:XX:XX] Error: /vscode/src/vs/editor/browser/controller/pointerHandler.ts(45,45): Property 'msTouchAction' does not exist on type 'CSSStyleDeclaration'. Did you mean 'touchAction'?
[XX:XX:XX] Error: /vscode/src/vs/editor/browser/controller/pointerHandler.ts(46,45): Property 'msContentZooming' does not exist on type 'CSSStyleDeclaration'.
[XX:XX:XX] Error: /vscode/src/vs/workbench/workbench.web.api.ts(249,25): Type 'readonly ICommand[] | undefined' must have a '[Symbol.iterator]()' method that returns an iterator.
[XX:XX:XX] Error: /vscode/src/vs/base/browser/ui/splitview/splitview.ts(113,3): Type '"none" | null' is not assignable to type 'string'.
[XX:XX:XX] Error: /vscode/src/vs/workbench/electron-browser/parts/titlebar/titlebarPart.ts(222,5): Type 'null' is not assignable to type 'string'.
[XX:XX:XX] Error: /vscode/src/vs/workbench/electron-browser/parts/titlebar/titlebarPart.ts(225,7): Type 'null' is not assignable to type 'string'.
[XX:XX:XX] Error: /vscode/src/vs/workbench/electron-browser/parts/titlebar/titlebarPart.ts(229,7): Type 'null' is not assignable to type 'string'.
[XX:XX:XX] Error: /vscode/src/vs/workbench/contrib/search/common/searchModel.ts(609,21): Type 'FileMatch | FileMatch[]' must have a '[Symbol.iterator]()' method that returns an iterator.
[XX:XX:XX] Error: /vscode/src/vs/workbench/browser/parts/titlebar/titlebarPart.ts(470,5): Type 'null' is not assignable to type 'string'.
[XX:XX:XX] Error: /vscode/src/vs/base/parts/quickinput/browser/quickInputList.ts(474,3): Type '"none" | null' is not assignable to type 'string'.
Type 'null' is not assignable to type 'string'.
[XX:XX:XX] Error: /vscode/src/vs/base/browser/ui/splitview/splitview.ts(113,3): Type '"none" | null' is not assignable to type 'string'.
Type 'null' is not assignable to type 'string'.
[XX:XX:XX] Error: /vscode/src/vs/editor/browser/controller/pointerHandler.ts(45,45): Property 'msTouchAction' does not exist on type 'CSSStyleDeclaration'. Did you mean 'touchAction'?
[XX:XX:XX] Error: /vscode/src/vs/editor/browser/controller/pointerHandler.ts(46,45): Property 'msContentZooming' does not exist on type 'CSSStyleDeclaration'.
[XX:XX:XX] Error: /vscode/src/vs/workbench/workbench.web.api.ts(249,25): Type 'readonly ICommand[] | undefined' must have a '[Symbol.iterator]()' method that returns an iterator.
[XX:XX:XX] Error: /vscode/src/vs/base/browser/ui/splitview/splitview.ts(113,3): Type '"none" | null' is not assignable to type 'string'.
[XX:XX:XX] Error: /vscode/src/vs/workbench/services/search/common/search.ts(617,20): This condition will always return true since the function is always defined. Did you mean to call it instead?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comes from #35862 and the couple of examples I poked at look correct; @mjbvz you'll probably want to fix these soonish.

[XX:XX:XX] Error: /vscode/src/vs/workbench/contrib/webview/electron-browser/webviewCommands.ts(156,13): This condition will always return true since the function is always defined. Did you mean to call it instead?
[XX:XX:XX] Error: /vscode/src/vs/workbench/contrib/scm/browser/repositoryPane.ts(809,7): This condition will always return true since the function is always defined. Did you mean to call it instead?
[XX:XX:XX] Error: /vscode/src/vs/workbench/contrib/preferences/browser/preferencesSearch.ts(522,18): This condition will always return true since the function is always defined. Did you mean to call it instead?
[XX:XX:XX] Error: /vscode/src/vs/workbench/api/common/extHostDebugService.ts(1075,7): This condition will always return true since the function is always defined. Did you mean to call it instead?
[XX:XX:XX] Error: /vscode/src/vs/workbench/api/common/extHostDebugService.ts(1087,7): This condition will always return true since the function is always defined. Did you mean to call it instead?
[XX:XX:XX] Error: /vscode/src/vs/workbench/api/common/extHostDebugService.ts(1093,7): This condition will always return true since the function is always defined. Did you mean to call it instead?
[XX:XX:XX] Error: /vscode/src/vs/editor/contrib/hover/hoverOperation.ts(146,7): This condition will always return true since the function is always defined. Did you mean to call it instead?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not clear whether to trust the types or the values in this case, but they definitely don't agree.

[XX:XX:XX] Error: /vscode/src/vs/editor/contrib/hover/hoverOperation.ts(160,7): This condition will always return true since the function is always defined. Did you mean to call it instead?
[XX:XX:XX] Error: /vscode/src/vs/base/browser/mouseEvent.ts(83,7): This condition will always return true since the function is always defined. Did you mean to call it instead?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upon reading more examples, they look like they're just leftovers from pre-strictNullChecks that the compiler didn't notice before.

[XX:XX:XX] Error: /vscode/src/vs/base/browser/mouseEvent.ts(89,7): This condition will always return true since the function is always defined. Did you mean to call it instead?
[XX:XX:XX] Error: /vscode/src/vs/base/browser/mouseEvent.ts(211,8): This condition will always return true since the function is always defined. Did you mean to call it instead?
[XX:XX:XX] Error: /vscode/src/vs/base/browser/mouseEvent.ts(219,8): This condition will always return true since the function is always defined. Did you mean to call it instead?
[XX:XX:XX] Error: /vscode/src/vs/workbench/services/search/common/search.ts(617,20): This condition will always return true since the function is always defined. Did you mean to call it instead?
[XX:XX:XX] Error: /vscode/src/vs/workbench/contrib/webview/electron-browser/webviewCommands.ts(156,13): This condition will always return true since the function is always defined. Did you mean to call it instead?
[XX:XX:XX] Error: /vscode/src/vs/workbench/contrib/scm/browser/repositoryPane.ts(809,7): This condition will always return true since the function is always defined. Did you mean to call it instead?
[XX:XX:XX] Error: /vscode/src/vs/workbench/contrib/preferences/browser/preferencesSearch.ts(522,18): This condition will always return true since the function is always defined. Did you mean to call it instead?
[XX:XX:XX] Error: /vscode/src/vs/workbench/api/common/extHostDebugService.ts(1075,7): This condition will always return true since the function is always defined. Did you mean to call it instead?
[XX:XX:XX] Error: /vscode/src/vs/workbench/api/common/extHostDebugService.ts(1087,7): This condition will always return true since the function is always defined. Did you mean to call it instead?
[XX:XX:XX] Error: /vscode/src/vs/workbench/api/common/extHostDebugService.ts(1093,7): This condition will always return true since the function is always defined. Did you mean to call it instead?
[XX:XX:XX] Error: /vscode/src/vs/editor/contrib/hover/hoverOperation.ts(146,7): This condition will always return true since the function is always defined. Did you mean to call it instead?
[XX:XX:XX] Error: /vscode/src/vs/editor/contrib/hover/hoverOperation.ts(160,7): This condition will always return true since the function is always defined. Did you mean to call it instead?
[XX:XX:XX] Error: /vscode/src/vs/base/browser/mouseEvent.ts(83,7): This condition will always return true since the function is always defined. Did you mean to call it instead?
[XX:XX:XX] Error: /vscode/src/vs/base/browser/mouseEvent.ts(89,7): This condition will always return true since the function is always defined. Did you mean to call it instead?
[XX:XX:XX] Error: /vscode/src/vs/base/browser/mouseEvent.ts(211,8): This condition will always return true since the function is always defined. Did you mean to call it instead?
[XX:XX:XX] Error: /vscode/src/vs/base/browser/mouseEvent.ts(219,8): This condition will always return true since the function is always defined. Did you mean to call it instead?
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.



Standard error:
[XX:XX:XX] 'compile' errored after
[XX:XX:XX] Error: Found 10 errors
[XX:XX:XX] Error: Found 13 errors
at Stream.<anonymous> (/vscode/build/lib/reporter.js:75:29)
at _end (/vscode/node_modules/through/index.js:65:9)
at Stream.stream.end (/vscode/node_modules/through/index.js:74:5)
Expand Down
24 changes: 12 additions & 12 deletions tests/baselines/reference/docker/vue-next.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Exit Code: 0
Standard output:

> @X.X.X-alpha.9 build /vue-next
> @X.X.X-alpha.10 build /vue-next
> node scripts/build.js "--types"
Rolling up type definitions for compiler-core...
Writing: /vue-next/temp/compiler-core.api.json
Expand Down Expand Up @@ -75,27 +75,27 @@ created packages/reactivity/dist/reactivity.global.prod.js in ?s
/vue-next/packages/reactivity/src/index.ts → packages/reactivity/dist/reactivity.esm.prod.js...
created packages/reactivity/dist/reactivity.esm.prod.js in ?s
/vue-next/packages/runtime-core/src/index.ts → packages/runtime-core/dist/runtime-core.esm-bundler.js...
[!] (plugin rpt2) Error: /vue-next/packages/runtime-core/src/apiOptions.ts(137,18): semantic error TS2344: Type 'Function & T[key]["get"]' does not satisfy the constraint '(...args: any) => any'.
[!] (plugin rpt2) Error: /vue-next/packages/runtime-core/src/apiOptions.ts(143,18): semantic error TS2344: Type 'Function & T[key]["get"]' does not satisfy the constraint '(...args: any) => any'.
Type 'Function' provides no match for the signature '(...args: any): any'.
packages/runtime-core/src/apiOptions.ts
Error: /vue-next/packages/runtime-core/src/apiOptions.ts(137,18): semantic error TS2344: Type 'Function & T[key]["get"]' does not satisfy the constraint '(...args: any) => any'.
Error: /vue-next/packages/runtime-core/src/apiOptions.ts(143,18): semantic error TS2344: Type 'Function & T[key]["get"]' does not satisfy the constraint '(...args: any) => any'.
Type 'Function' provides no match for the signature '(...args: any): any'.
at error (/vue-next/node_modules/rollup/dist/shared/node-entry.js:5400:30)
at throwPluginError (/vue-next/node_modules/rollup/dist/shared/node-entry.js:11878:12)
at Object.error (/vue-next/node_modules/rollup/dist/shared/node-entry.js:12912:24)
at Object.error (/vue-next/node_modules/rollup/dist/shared/node-entry.js:12081:38)
at error (/vue-next/node_modules/rollup/dist/shared/rollup.js:10120:30)
at throwPluginError (/vue-next/node_modules/rollup/dist/shared/rollup.js:16247:12)
at Object.error (/vue-next/node_modules/rollup/dist/shared/rollup.js:17255:24)
at Object.error (/vue-next/node_modules/rollup/dist/shared/rollup.js:16420:38)
at RollupContext.error (/vue-next/node_modules/rollup-plugin-typescript2/src/rollupcontext.ts:37:18)
at /vue-next/node_modules/rollup-plugin-typescript2/src/print-diagnostics.ts:41:11
at arrayEach (/vue-next/node_modules/rollup-plugin-typescript2/node_modules/lodash/lodash.js:516:11)
at forEach (/vue-next/node_modules/rollup-plugin-typescript2/node_modules/lodash/lodash.js:9342:14)
at _.each (/vue-next/node_modules/rollup-plugin-typescript2/src/print-diagnostics.ts:9:2)
at Object.transform (/vue-next/node_modules/rollup-plugin-typescript2/src/index.ts:234:5)
(node:17) UnhandledPromiseRejectionWarning: Error: Command failed with exit code 1 (EPERM): rollup -c --environment COMMIT:342d46d,NODE_ENV:production,TARGET:runtime-core,TYPES:true
at Object.transform (/vue-next/node_modules/rollup-plugin-typescript2/src/index.ts:242:5)
(node:17) UnhandledPromiseRejectionWarning: Error: Command failed with exit code 1 (EPERM): rollup -c --environment COMMIT:94562da,NODE_ENV:production,TARGET:runtime-core,TYPES:true
at makeError (/vue-next/node_modules/execa/lib/error.js:59:11)
at handlePromise (/vue-next/node_modules/execa/index.js:112:26)
at processTicksAndRejections (internal/process/task_queues.js:97:5)
at async build (/vue-next/scripts/build.js:72:3)
at async buildAll (/vue-next/scripts/build.js:51:5)
at async run (/vue-next/scripts/build.js:41:5)
at async build (/vue-next/scripts/build.js:71:3)
at async buildAll (/vue-next/scripts/build.js:50:5)
at async run (/vue-next/scripts/build.js:40:5)
(node:17) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:17) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
15 changes: 1 addition & 14 deletions tests/baselines/reference/docker/xterm.js.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,9 @@
Exit Code: 2
Exit Code: 0
Standard output:

> [email protected] build /xtermjs
> tsc -b ./tsconfig.all.json
node_modules/@types/ws/index.d.ts(44,39): error TS2694: Namespace '"url"' has no exported member 'URL'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specific to master -- did @types/ws just update?

node_modules/@types/ws/index.d.ts(45,39): error TS2694: Namespace '"url"' has no exported member 'URL'.
node_modules/@types/ws/index.d.ts(44,39): error TS2694: Namespace '"url"' has no exported member 'URL'.
node_modules/@types/ws/index.d.ts(45,39): error TS2694: Namespace '"url"' has no exported member 'URL'.



Standard error:
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! [email protected] build: `tsc -b ./tsconfig.all.json`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the [email protected] build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /root/.npm/_logs/XXXX-XX-XXXXXXXXX-debug.log
13 changes: 7 additions & 6 deletions tests/baselines/reference/user/chrome-devtools-frontend.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10234,6 +10234,7 @@ node_modules/chrome-devtools-frontend/front_end/security/SecurityPanel.js(323,3)
Type 'T' is not assignable to type 'SecurityModel'.
node_modules/chrome-devtools-frontend/front_end/security/SecurityPanel.js(375,25): error TS2694: Namespace 'Protocol' has no exported member 'Security'.
node_modules/chrome-devtools-frontend/front_end/security/SecurityPanel.js(376,25): error TS2694: Namespace 'Protocol' has no exported member 'Network'.
node_modules/chrome-devtools-frontend/front_end/security/SecurityPanel.js(377,23): error TS1099: Type argument list cannot be empty.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is new, and correct

node_modules/chrome-devtools-frontend/front_end/security/SecurityPanel.js(389,14): error TS7014: Function type, which lacks return-type annotation, implicitly has an 'any' return type.
node_modules/chrome-devtools-frontend/front_end/security/SecurityPanel.js(416,59): error TS2555: Expected at least 2 arguments, but got 1.
node_modules/chrome-devtools-frontend/front_end/security/SecurityPanel.js(440,24): error TS2694: Namespace 'Protocol' has no exported member 'Security'.
Expand Down Expand Up @@ -10408,9 +10409,9 @@ node_modules/chrome-devtools-frontend/front_end/source_frame/FontView.js(38,18):
node_modules/chrome-devtools-frontend/front_end/source_frame/FontView.js(62,16): error TS2339: Property 'sprintf' does not exist on type 'StringConstructor'.
node_modules/chrome-devtools-frontend/front_end/source_frame/FontView.js(78,21): error TS2339: Property 'createChild' does not exist on type 'Element'.
node_modules/chrome-devtools-frontend/front_end/source_frame/FontView.js(79,19): error TS2339: Property 'createTextChild' does not exist on type 'Element'.
node_modules/chrome-devtools-frontend/front_end/source_frame/FontView.js(82,29): error TS2339: Property 'style' does not exist on type 'Element'.
node_modules/chrome-devtools-frontend/front_end/source_frame/FontView.js(83,29): error TS2339: Property 'style' does not exist on type 'Element'.
node_modules/chrome-devtools-frontend/front_end/source_frame/FontView.js(84,29): error TS2339: Property 'style' does not exist on type 'Element'.
node_modules/chrome-devtools-frontend/front_end/source_frame/FontView.js(82,29): error TS2339: Property 'style' does not exist on type 'Node'.
node_modules/chrome-devtools-frontend/front_end/source_frame/FontView.js(83,29): error TS2339: Property 'style' does not exist on type 'Node'.
node_modules/chrome-devtools-frontend/front_end/source_frame/FontView.js(84,29): error TS2339: Property 'style' does not exist on type 'Node'.
node_modules/chrome-devtools-frontend/front_end/source_frame/FontView.js(87,24): error TS2339: Property 'style' does not exist on type 'Element'.
node_modules/chrome-devtools-frontend/front_end/source_frame/FontView.js(88,24): error TS2339: Property 'style' does not exist on type 'Element'.
node_modules/chrome-devtools-frontend/front_end/source_frame/FontView.js(89,24): error TS2339: Property 'style' does not exist on type 'Element'.
Expand All @@ -10419,11 +10420,11 @@ node_modules/chrome-devtools-frontend/front_end/source_frame/FontView.js(91,24):
node_modules/chrome-devtools-frontend/front_end/source_frame/FontView.js(92,24): error TS2339: Property 'style' does not exist on type 'Element'.
node_modules/chrome-devtools-frontend/front_end/source_frame/FontView.js(123,45): error TS2339: Property 'offsetWidth' does not exist on type 'Element'.
node_modules/chrome-devtools-frontend/front_end/source_frame/FontView.js(123,85): error TS2339: Property 'offsetHeight' does not exist on type 'Element'.
node_modules/chrome-devtools-frontend/front_end/source_frame/FontView.js(133,29): error TS2339: Property 'style' does not exist on type 'Element'.
node_modules/chrome-devtools-frontend/front_end/source_frame/FontView.js(133,29): error TS2339: Property 'style' does not exist on type 'Node'.
node_modules/chrome-devtools-frontend/front_end/source_frame/FontView.js(140,41): error TS2339: Property 'offsetWidth' does not exist on type 'Element'.
node_modules/chrome-devtools-frontend/front_end/source_frame/FontView.js(141,42): error TS2339: Property 'offsetHeight' does not exist on type 'Element'.
node_modules/chrome-devtools-frontend/front_end/source_frame/FontView.js(144,31): error TS2339: Property 'style' does not exist on type 'Element'.
node_modules/chrome-devtools-frontend/front_end/source_frame/FontView.js(152,29): error TS2339: Property 'style' does not exist on type 'Element'.
node_modules/chrome-devtools-frontend/front_end/source_frame/FontView.js(144,31): error TS2339: Property 'style' does not exist on type 'Node'.
node_modules/chrome-devtools-frontend/front_end/source_frame/FontView.js(152,29): error TS2339: Property 'style' does not exist on type 'Node'.
node_modules/chrome-devtools-frontend/front_end/source_frame/ImageView.js(38,18): error TS2555: Expected at least 2 arguments, but got 1.
node_modules/chrome-devtools-frontend/front_end/source_frame/ImageView.js(52,88): error TS2555: Expected at least 2 arguments, but got 1.
node_modules/chrome-devtools-frontend/front_end/source_frame/ImageView.js(58,36): error TS2339: Property 'createChild' does not exist on type 'Element'.
Expand Down
Loading