Add support of contextual quick info #37451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kingwl
force-pushed
the
quick_info_contextual
branch
from
50d62d7 to
efbf539
Compare
src/services/services.ts
Outdated
| @@ -283,6 +283,12 @@ namespace ts { | |||
| } | |||
| } | |||
|
|
|||
| enum ContextualDocumentationType { | |||
| None = "None", | |||
There was a problem hiding this comment.
Nit: we prefer (usually numeric) const enums for efficiency
There was a problem hiding this comment.
Seems Map interface cannot work with the numerical enum, does it?
There was a problem hiding this comment.
It doesn't need to be map.. Jus two properties that store array of decl comments one for get and one for set accessor ?
There was a problem hiding this comment.
Okay...but I felt maybe it will take more contextual info in the future. For example getter or setter in LHS or RHS
There was a problem hiding this comment.
But never mind, We could refactor in time.
Kingwl
force-pushed
the
quick_info_contextual
branch
from
91cb068 to
98eb23a
Compare
sheetalkamat
approved these changes
Mar 24, 2020
|
up 🆙 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20966