Always generate configFileDiag if file is going to be added to configured project #37443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheetalkamat
commented
Mar 17, 2020
| getUnknownCompilerOptionDiagnostic(configFile, "allowJS", "allowJs") | ||
| ]); | ||
| openFilesForSession([file], serverEventManager.session); | ||
| // We generate only if project is created when opening file from the project | ||
| serverEventManager.hasZeroEvent("configFileDiag"); |
There was a problem hiding this comment.
@mjbvz Want you to ensure that this still holds. That is if file is opened from configured project, configFileDiag is generated only if project is created as part of the open operation
…ured project Fixes #30623
sheetalkamat
force-pushed
the
configFileDiag
branch
from
9ef4a73 to
4473323
Compare
mjbvz
approved these changes
Mar 17, 2020
|
@typescript-bot pack this |
|
Heya @sheetalkamat, I've started to run the tarball bundle task on this PR at 4473323. You can monitor the build here. |
|
Hey @sheetalkamat, I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running There is also a playground for this build. |
|
Tested in VS Code. Looks like we show the diagnostic that TS server generates with this change:
|
andrewbranch
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30623