Skip to content

Emit an any for namepath types #37176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/compiler/checker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6330,7 +6330,8 @@ namespace ts {
return result;

function visitExistingNodeTreeSymbols<T extends Node>(node: T): Node {
if (isJSDocAllType(node)) {
// We don't _actually_ support jsdoc namepath types, emit `any` instead
if (isJSDocAllType(node) || node.kind === SyntaxKind.JSDocNamepathType) {
return createKeywordTypeNode(SyntaxKind.AnyKeyword);
}
if (isJSDocUnknownType(node)) {
Expand Down
47 changes: 47 additions & 0 deletions tests/baselines/reference/jsDeclarationsModuleReferenceHasEmit.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
//// [index.js]
/**
* @module A
*/
class A {}


/**
* Target element
* @type {module:A}
*/
export let el = null;

export default A;

//// [index.js]
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
exports.el = void 0;
/**
* @module A
*/
var A = /** @class */ (function () {
function A() {
}
return A;
}());
/**
* Target element
* @type {module:A}
*/
exports.el = null;
exports.default = A;


//// [index.d.ts]
/**
* Target element
* @type {module:A}
*/
export let el: any;
export default A;
/**
* @module A
*/
declare class A {
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
=== tests/cases/conformance/jsdoc/declarations/index.js ===
/**
* @module A
*/
class A {}
>A : Symbol(A, Decl(index.js, 0, 0))


/**
* Target element
* @type {module:A}
*/
export let el = null;
>el : Symbol(el, Decl(index.js, 10, 10))

export default A;
>A : Symbol(A, Decl(index.js, 0, 0))

Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
=== tests/cases/conformance/jsdoc/declarations/index.js ===
/**
* @module A
*/
class A {}
>A : A


/**
* Target element
* @type {module:A}
*/
export let el = null;
>el : error
>null : null

export default A;
>A : A

Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
// @allowJs: true
// @checkJs: true
// @target: es5
// @outDir: ./out
// @declaration: true
// @filename: index.js
/**
* @module A
*/
class A {}


/**
* Target element
* @type {module:A}
*/
export let el = null;

export default A;