exported declarations now don't take the exclusive slot #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| exportSymbol.localSymbols.push(localSymbol); | ||
| } | ||
| localSymbol.exportSymbol = exportSymbol; | ||
| } | ||
| else { |
There was a problem hiding this comment.
What is this else block for?
There was a problem hiding this comment.
It is for import aliases. An exported import alias doesn't have a local symbol.
|
I definitely like that we can reason about the local and exported symbols as a single entity, but I think it would be good to go over the logic behind this change on the whiteboard before we accept it. I just want to make sure we've covered everything. |
| if (!target.localSymbols) { | ||
| target.localSymbols = []; | ||
| } | ||
| forEach(source.localSymbols, node => { target.localSymbols.push(node); }); |
There was a problem hiding this comment.
No, they're being added to an already existing array.
|
@JsonFreeman @ahejlsberg can you check the latest revision? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export and local symbol are used to mutually exclude each other so having exported and non exported declarations with the same name that can be merged lead to 'Duplicate identifier' and as a consequence these declarations were attached to a different symbols.
Such layout makes declaration analysis extremely inconvenient since there are no easy way to reconstruct actual sequence of declarations in program
This PR allows exported and non exported declarations to share local symbol.