Skip to content

fix(34621): show suggestions in class property initializer #35999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2020
Merged

fix(34621): show suggestions in class property initializer #35999

merged 1 commit into from
Jan 17, 2020

Conversation

a-tarasyuk
Copy link
Contributor

@a-tarasyuk a-tarasyuk commented Jan 4, 2020 •
edited
Loading

Fixes #34621

@DanielRosenwasser
Copy link
Member

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 7, 2020 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at eb47d85. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 7, 2020 •
edited
Loading

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/59537/artifacts?artifactName=tgz&fileId=1EF79E046B2BBD20909DEB4B1440D4C150FBB983C1C5E794DF81C374CDE2026902&fileName=/typescript-3.8.0-insiders.20200107.tgz"
    }
}

and then running npm install.

There is also a playground for this build.

@DanielRosenwasser DanielRosenwasser changed the title fix(34621): No Suggestions in class property initializer fix(34621): show suggestions in class property initializer Jan 17, 2020
@DanielRosenwasser DanielRosenwasser merged commit afa11d3 into microsoft:master Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@sheetalkamat sheetalkamat sheetalkamat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No Suggestions in class property initializer
4 participants
@a-tarasyuk @DanielRosenwasser @typescript-bot @sheetalkamat