Remove redundant checker functions and use patterns more friendly to modules #35399
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So there's a couple small things bundled in here:
getObjectFlags
on checker was redundant. There's ats.getObjectFlags
that it was just a copy of. So it's gone now.checker.getObjectFlags
is removed) to use a local variable.Do note that I'm just opening PRs to fix/work around these things as they come up while I'm working on the module transition, and I figured it's much easier to review them in little bits like this, before the big switch over, assuming the new code still works both before and after the change.