Revert "Skip costly tests" #35197
Merged
Revert "Skip costly tests" #35197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
approved these changes
Nov 19, 2019
ahejlsberg
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skipping costly tests was intended to help team members who primarily develop on laptops by testing only the cheaper+commoner tests locally and letting CI catch the rest. But at least @ahejlsberg, as well as some community members, said they prefer a slower run to having to fix up CI failures. So I'm reverting it.
@SimenB continues to make progress on v8 code coverage in jest, so perhaps we'll be able to switch over to jest soon. Coverage-based test selection saves much more time in the common case.