Skip to content

strip QuestionToken from MethodDeclaration and PropertyDeclaration emit #34954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2019

Conversation

ajafff
Copy link
Contributor

@ajafff ajafff commented Nov 6, 2019

Fixes: #34953
Fixes: #34966

@ajafff ajafff changed the title strip QuestionToken from MethodDeclartion emit strip QuestionToken from MethodDeclaration and PropertyDeclaration emit Nov 7, 2019
@sandersn sandersn self-requested a review November 12, 2019 18:22
@sandersn sandersn merged commit 94f8590 into microsoft:master Nov 12, 2019
@sandersn
Copy link
Member

@typescript-bot cherry-pick this to release-3.7 please

@typescript-bot
Copy link
Collaborator

Hey @sandersn, I've opened #35059 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Nov 12, 2019
Component commits:
84ebe22 strip QuestionToken from MethodDeclartion emit
Fixes: microsoft#34953

5269071 test property emit
sandersn pushed a commit that referenced this pull request Nov 12, 2019
…it (#34954)

* strip QuestionToken from MethodDeclartion emit

Fixes: #34953

* test property emit
@sandersn
Copy link
Member

Manually cherry-picked to 3.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QuestionToken on PropertyDeclaration is not stripped from emit with useDefineForClassFields QuestionToken is not removed from method declaration emit
3 participants