Exclude types originating in literals from recursion depth limiter check #34742
Conversation
src/compiler/checker.ts
Outdated
| const symbol = type.symbol; | ||
| if (symbol) { | ||
| let count = 0; | ||
| for (let i = 0; i < depth; i++) { | ||
| const t = stack[i]; | ||
| if (t.flags & TypeFlags.Object && t.symbol === symbol) { | ||
| if (t.flags & TypeFlags.Object && t.symbol === symbol && !isObjectOrArrayLiteralType(t)) { |
There was a problem hiding this comment.
If two types have the same symbol and one of them is already known not to be an array or object literal type, how could the other possibly be? Under what scenarios does this need to be checked here, too?
|
@typescript-bot run dt |
|
Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 00570a1. You can monitor the build here. It should now contribute to this PR's status checks. |
|
@typescript-bot test this |
|
Heya @ahejlsberg, I've started to run the extended test suite on this PR at 00570a1. You can monitor the build here. It should now contribute to this PR's status checks. |
|
RWC tests are clean. DT tests have one new error in tests for |
|
Is there a case where there's an object literal type that's provided as an argument to a symbolless generic (indexed access?) thats somehow nonterminating now? |
|
Don't think so. But if there is, then there is now as well since literals by themselves can't be circular. |
Fixes #34619.