Fix regression in mixin emit by removing unneeded line of code #34715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
approved these changes
Oct 24, 2019
|
@typescript-bot cherry-pick this into release-3.7 |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Oct 24, 2019
|
Hey @weswigham, I've opened #34719 for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33739
Just removes a line of code added alongside the js declaration emitter whose purpose should be duplicated by the
isValueSymbolAccessibleon the following line, and so only served to break people ❤️