Do not consider element accesses which are neither statically bindable nor late bound as special assignments #34679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e nor late bound as special assignments
weswigham
requested review from
DanielRosenwasser,
andrewbranch and
uniqueiniquity
andrewbranch
approved these changes
Oct 23, 2019
|
@typescript-bot cherry-pick this to release-3.7 |
|
Hey @DanielRosenwasser, I've opened #34680 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Oct 23, 2019
Component commits: e0b98c6 Do not consider element accesses which are neither statically bindable nor late bound as special assignments
|
Actually no. @typescript-bot cherry-pick this to branchname and LKG |
|
Heya @DanielRosenwasser, I couldn't find the branch 'branchname' on Microsoft/TypeScript. You may need to make it and try again. |
|
Heya @DanielRosenwasser, I couldn't find the branch 'branchname' on Microsoft/TypeScript. You may need to make it and try again. |
|
@typescript-bot cherry-pick this to release-3.7 and LKG |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Oct 23, 2019
Component commits: e0b98c6 Do not consider element accesses which are neither statically bindable nor late bound as special assignments
|
Hey @DanielRosenwasser, I've opened #34681 for you. |
DanielRosenwasser
pushed a commit
that referenced
this pull request
Oct 23, 2019
Component commits: e0b98c6 Do not consider element accesses which are neither statically bindable nor late bound as special assignments
mheiber
pushed a commit
to mheiber/TypeScript
that referenced
this pull request
Oct 25, 2019
…e nor late bound as special assignments (microsoft#34679)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34672