Treat any mix of element/prop access as declaration in JS #34649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #34642 but, notably, doesn't actually make the assignment into a working declaration. It just fixes the crash.
sandersn
commented
Oct 22, 2019
| return isLiteralLikeElementAccess(node) | ||
| && ((!excludeThisKeyword && node.expression.kind === SyntaxKind.ThisKeyword) || | ||
| isEntityNameExpression(node.expression) || | ||
| isBindableStaticAccessExpression(node.expression, /*excludeThisKeyword*/ true)); |
There was a problem hiding this comment.
the fix is actually here: previously it called isBindableStaticElementAccessExpression, which meant that element accesses had to be trailing; they were not allowed to be interspersed.
andrewbranch
approved these changes
Oct 22, 2019
|
@RyanCavanaugh this needs to be cherry-picked into release-3.7, right? I'm not sure what the RC release state is. |
|
@typescript-bot cherry-pick this |
|
@typescript-bot cherry-pick this to release-3.7 And next time reply with syntax help |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Oct 22, 2019
Component commits: b674481 Treat any mix of element/prop access as declaration in JS Fixes microsoft#34642 but, notably, doesn't actually make the assignment into a working declaration. It just fixes the crash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34642 but, notably, doesn't actually make the assignment into a working declaration. It just fixes the crash.