Stop pre-emptively creating directories #34521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking for directory existence is expensive and frequently indicates success. Instead of pre-emptively creating the directory containing a file to be written, attempt to create the file and only do the directory scaffolding if the write fails. Appears to reduce file write time by 10-20% for a file-I/O heavy partner build. Thanks to @rbuckton for the suggestion!
|
@typescript-bot perf test |
|
Heya @amcasey, I've started to run the perf test suite on this PR at b6659e5. You can monitor the build here. It should now contribute to this PR's status checks. Update: The results are in! |
|
@amcasey Here they are:Comparison Report - master..34521
System
Hosts
Scenarios
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
👍 but get sign off from others. |
sheetalkamat
requested changes
Oct 17, 2019
sheetalkamat
approved these changes
Oct 21, 2019
src/compiler/program.ts
Outdated
| fileName, | ||
| data, | ||
| writeByteOrderMark, | ||
| (f, d, w) => writeFileWorker(f, d, w), |
There was a problem hiding this comment.
parameter names seem not very friendly
There was a problem hiding this comment.
I was trying to convey that they're just threaded through to writeFileWorker. If full names are more conventional, I'm happy to expand them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking for directory existence is expensive and frequently indicates success. Instead of pre-emptively creating the directory containing a file to be written, attempt to create the file and only do the directory scaffolding if the write fails.
Appears to reduce file write time by 10-20% for a file-I/O heavy partner build.
Thanks to @rbuckton for the suggestion!