Remove all submodules - just force clone and reset on run instead #33425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@typescript-bot user test this |
|
Heya @weswigham, I've started to run the parallelized community code test suite on this PR at e5d7323. You can monitor the build here. It should now contribute to this PR's status checks. |
weswigham
force-pushed
the
remove-submodules
branch
from
e5d7323 to
b8cc506
Compare
|
@typescript-bot user test this |
|
Heya @weswigham, I've started to run the parallelized community code test suite on this PR at b8cc506. You can monitor the build here. It should now contribute to this PR's status checks. |
andrewbranch
approved these changes
Sep 13, 2019
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I give up - submodules are broken and a failed experiment.
ignore = allisn't respected in the.gitmoduleslike it should be, resulting in us continuously having stupid diffs and "merge conflicts" in the submodule references, thanks to the daily user run now consistently updating them. It's a little less integrated, but this has the same effect but less brokenness in version control - we now just clone (or reset and update the existing clone) on test start, and ignore the clone's directory. In a way, this is just us implementing submodules in a way that actually works T.T