Skip to content

Fix visitLexicalEnvironment to properly merge hoisted declarations #33219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2019

Conversation

rbuckton
Copy link
Contributor

@rbuckton rbuckton commented Sep 3, 2019

Fixes #33217

@rbuckton rbuckton requested a review from weswigham September 3, 2019 21:04
@rbuckton
Copy link
Contributor Author

rbuckton commented Sep 3, 2019

I'll need to either cherry-pick and open this against release-3.6 as well.

@rbuckton
Copy link
Contributor Author

rbuckton commented Sep 3, 2019

@typescript-bot cherry-pick this into release-3.6

@typescript-bot
Copy link
Collaborator

Hey @rbuckton, I've opened #33222 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Sep 3, 2019
Component commits:
ffc82db Fix visitLexicalEnvironment to properly merge hoisted declarations
@rbuckton rbuckton mentioned this pull request Sep 3, 2019
7 tasks
rbuckton pushed a commit that referenced this pull request Sep 3, 2019
Component commits:
ffc82db Fix visitLexicalEnvironment to properly merge hoisted declarations
@rbuckton rbuckton merged commit 3b96729 into master Sep 3, 2019
@rbuckton rbuckton deleted the fix33217 branch September 3, 2019 22:29
timsuchanek pushed a commit to timsuchanek/TypeScript that referenced this pull request Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect emit for hoisted variables and "use strict" at the top of a file.
3 participants