Fixes #32923 #33148
Merged
Fixes #32923 #33148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amcasey
approved these changes
Aug 29, 2019
|
|
||
| //// | ||
| //// var clear = {}; | ||
| //// clear = |
There was a problem hiding this comment.
I liked the || example you mentioned offline - add a test for that too?
There was a problem hiding this comment.
I will take the opportunity to make this test more minimal - it's copied out of another test and I don't like how redundant it is
minestarks
force-pushed
the
formatting-object-literals
branch
from
04d4db5 to
9781b95
Compare
jessetrinity
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32923