generate import statements and replace import types when implementing interface #28165 #33126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
keotl
changed the title
|
Cross-post-ish from #28165 (comment): I fixed this bug with #36615, which is already shipped with TypeScript 3.8. #34995, the issue I was assigned, was never marked as a duplicate of this one, and so I was never aware of the existence of #28165 or your work on this PR here. Sadly this happens from time to time in a repo with thousands of issues, but my apologies for the mixup nonetheless. Thanks for the contribution, and I hope this doesn’t permanently sour your experience contributing to TypeScript—we’ll try to do a better job triaging if you decide to come back with another PR in the future. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28165
Fixes an issue where adding implemented members yields locally-imported types.