Skip to content

🤖 User test baselines have changed #33083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2019
Merged

🤖 User test baselines have changed #33083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 80 additions & 3 deletions tests/baselines/reference/docker/azure-sdk.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Exit Code: 1
Standard output:

Rush Multi-Project Build Tool 5.X.X - https://rushjs.io
Node.js version is 12.8.1 (pre-LTS)
Node.js version is 12.9.0 (pre-LTS)
Starting "rush rebuild"
Executing a maximum of ?simultaneous processes...
XX of XX: [@azure/abort-controller] completed successfully in ? seconds
Expand All @@ -28,10 +28,45 @@ npm ERR! A complete log of this run can be found in:
npm ERR! /root/.npm/_logs/XXXX-XX-XXXXXXXXX-debug.log
ERROR: "build:lib" exited with 1.
XX of XX: [@azure/event-processor-host] completed successfully in ? seconds
XX of XX: [@azure/test-utils-recorder] completed successfully in ? seconds
XX of XX: [@azure/core-asynciterator-polyfill] completed successfully in ? seconds
XX of XX: [@azure/core-paging] completed successfully in ? seconds
XX of XX: [@azure/core-tracing] completed successfully in ? seconds
XX of XX: [@azure/service-bus] completed successfully in ? seconds
Warning: You have changed the public API signature for this project. Updating review/cosmos.api.md
dist-esm/index.js → dist/index.js...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these warnings are new, and might be bad.

(!) Unresolved dependencies
https://rollupjs.org/guide/en/#warning-treating-module-as-external-dependency
tslib (imported by dist-esm/queryIterator.js, dist-esm/auth.js, dist-esm/CosmosClient.js, dist-esm/plugins/Plugin.js, dist-esm/ClientContext.js, dist-esm/globalEndpointManager.js, dist-esm/client/Conflict/Conflict.js, dist-esm/client/Container/Container.js, dist-esm/client/Container/Containers.js, dist-esm/client/Database/Database.js, dist-esm/client/Database/Databases.js, dist-esm/client/Item/Item.js, dist-esm/client/Item/Items.js, dist-esm/client/Offer/Offer.js, dist-esm/client/Permission/Permission.js, dist-esm/client/Permission/Permissions.js, dist-esm/client/StoredProcedure/StoredProcedure.js, dist-esm/client/StoredProcedure/StoredProcedures.js, dist-esm/client/Trigger/Trigger.js, dist-esm/client/Trigger/Triggers.js, dist-esm/client/User/User.js, dist-esm/client/User/Users.js, dist-esm/client/UserDefinedFunction/UserDefinedFunction.js, dist-esm/client/UserDefinedFunction/UserDefinedFunctions.js, dist-esm/queryExecutionContext/defaultQueryExecutionContext.js, dist-esm/queryExecutionContext/documentProducer.js, dist-esm/queryExecutionContext/parallelQueryExecutionContextBase.js, dist-esm/queryExecutionContext/pipelinedQueryExecutionContext.js, dist-esm/request/request.js, dist-esm/request/RequestHandler.js, dist-esm/ChangeFeedIterator.js, dist-esm/routing/smartRoutingMapProvider.js, dist-esm/queryExecutionContext/EndpointComponent/AggregateEndpointComponent.js, dist-esm/queryExecutionContext/EndpointComponent/OffsetLimitEndpointComponent.js, dist-esm/queryExecutionContext/EndpointComponent/OrderByEndpointComponent.js, dist-esm/queryExecutionContext/EndpointComponent/OrderedDistinctEndpointComponent.js, dist-esm/queryExecutionContext/EndpointComponent/UnorderedDistinctEndpointComponent.js, dist-esm/retry/retryUtility.js, dist-esm/routing/partitionKeyRangeCache.js, dist-esm/retry/defaultRetryPolicy.js, dist-esm/retry/endpointDiscoveryRetryPolicy.js, dist-esm/retry/resourceThrottleRetryPolicy.js, dist-esm/retry/sessionRetryPolicy.js)
@azure/cosmos-sign (imported by dist-esm/auth.js)
universal-user-agent (imported by dist-esm/common/platform.js)
uuid/v4 (imported by dist-esm/client/Item/Items.js)
binary-search-bounds (imported by dist-esm/queryExecutionContext/parallelQueryExecutionContextBase.js, dist-esm/routing/inMemoryCollectionRoutingMap.js)
priorityqueuejs (imported by dist-esm/queryExecutionContext/parallelQueryExecutionContextBase.js)
semaphore (imported by dist-esm/queryExecutionContext/parallelQueryExecutionContextBase.js)
node-abort-controller (imported by dist-esm/request/RequestHandler.js)
node-fetch (imported by dist-esm/request/RequestHandler.js)
atob (imported by dist-esm/session/sessionContainer.js)
crypto-hash (imported by dist-esm/queryExecutionContext/EndpointComponent/OrderedDistinctEndpointComponent.js, dist-esm/queryExecutionContext/EndpointComponent/UnorderedDistinctEndpointComponent.js)
fast-json-stable-stringify (imported by dist-esm/queryExecutionContext/EndpointComponent/OrderedDistinctEndpointComponent.js, dist-esm/queryExecutionContext/EndpointComponent/UnorderedDistinctEndpointComponent.js)
(!) Missing global variable names
Use output.globals to specify browser global variable names corresponding to external modules
universal-user-agent (guessing 'userAgent')
tslib (guessing 'tslib')
@azure/cosmos-sign (guessing 'cosmosSign')
binary-search-bounds (guessing 'bs')
priorityqueuejs (guessing 'PriorityQueue')
semaphore (guessing 'semaphore')
crypto-hash (guessing 'cryptoHash')
fast-json-stable-stringify (guessing 'stableStringify')
uuid/v4 (guessing 'uuid')
node-abort-controller (guessing 'AbortController')
node-fetch (guessing 'fetch')
atob (guessing 'atob')
(!) Circular dependency: dist-esm/queryExecutionContext/index.js -> dist-esm/queryExecutionContext/headerUtils.js -> dist-esm/queryMetrics/index.js -> dist-esm/queryMetrics/clientSideMetrics.js -> dist-esm/queryExecutionContext/index.js
(!) Circular dependency: dist-esm/index.js -> dist-esm/CosmosClient.js -> dist-esm/client/Database/index.js -> dist-esm/client/Database/Database.js -> dist-esm/client/Container/index.js -> dist-esm/client/Container/Container.js -> dist-esm/client/Script/Scripts.js -> dist-esm/index.js
(!) Circular dependency: dist-esm/request/RequestHandler.js -> dist-esm/retry/retryUtility.js -> dist-esm/request/RequestHandler.js
created dist/index.js in ?s
Warning: You have changed the public API signature for this project. Updating review/service-bus.api.md
XX of XX: [@azure/storage-blob] completed successfully in ? seconds
XX of XX: [@azure/storage-file] completed successfully in ? seconds
XX of XX: [@azure/storage-queue] completed successfully in ? seconds
Expand All @@ -41,15 +76,55 @@ SUCCESS (11)
@azure/abort-controller (? seconds)
@azure/core-auth (? seconds)
@azure/event-processor-host (? seconds)
@azure/test-utils-recorder (? seconds)
@azure/core-asynciterator-polyfill (? seconds)
@azure/core-paging (? seconds)
@azure/core-tracing (? seconds)
@azure/service-bus (? seconds)
@azure/storage-blob (? seconds)
@azure/storage-file (? seconds)
@azure/storage-queue (? seconds)
testhub (? seconds)
================================
SUCCESS WITH WARNINGS (2)
================================
@azure/cosmos (? seconds)
Warning: You have changed the public API signature for this project. Updating review/cosmos.api.md
dist-esm/index.js → dist/index.js...
(!) Unresolved dependencies
https://rollupjs.org/guide/en/#warning-treating-module-as-external-dependency
tslib (imported by dist-esm/queryIterator.js, dist-esm/auth.js, dist-esm/CosmosClient.js, dist-esm/plugins/Plugin.js, dist-esm/ClientContext.js, dist-esm/globalEndpointManager.js, dist-esm/client/Conflict/Conflict.js, dist-esm/client/Container/Container.js, dist-esm/client/Container/Containers.js, dist-esm/client/Database/Database.js, dist-esm/client/Database/Databases.js, dist-esm/client/Item/Item.js, dist-esm/client/Item/Items.js, dist-esm/client/Offer/Offer.js, dist-esm/client/Permission/Permission.js, dist-esm/client/Permission/Permissions.js, dist-esm/client/StoredProcedure/StoredProcedure.js, dist-esm/client/StoredProcedure/StoredProcedures.js, dist-esm/client/Trigger/Trigger.js, dist-esm/client/Trigger/Triggers.js, dist-esm/client/User/User.js, dist-esm/client/User/Users.js, dist-esm/client/UserDefinedFunction/UserDefinedFunction.js, dist-esm/client/UserDefinedFunction/UserDefinedFunctions.js, dist-esm/queryExecutionContext/defaultQueryExecutionContext.js, dist-esm/queryExecutionContext/documentProducer.js, dist-esm/queryExecutionContext/parallelQueryExecutionContextBase.js, dist-esm/queryExecutionContext/pipelinedQueryExecutionContext.js, dist-esm/request/request.js, dist-esm/request/RequestHandler.js, dist-esm/ChangeFeedIterator.js, dist-esm/routing/smartRoutingMapProvider.js, dist-esm/queryExecutionContext/EndpointComponent/AggregateEndpointComponent.js, dist-esm/queryExecutionContext/EndpointComponent/OffsetLimitEndpointComponent.js, dist-esm/queryExecutionContext/EndpointComponent/OrderByEndpointComponent.js, dist-esm/queryExecutionContext/EndpointComponent/OrderedDistinctEndpointComponent.js, dist-esm/queryExecutionContext/EndpointComponent/UnorderedDistinctEndpointComponent.js, dist-esm/retry/retryUtility.js, dist-esm/routing/partitionKeyRangeCache.js, dist-esm/retry/defaultRetryPolicy.js, dist-esm/retry/endpointDiscoveryRetryPolicy.js, dist-esm/retry/resourceThrottleRetryPolicy.js, dist-esm/retry/sessionRetryPolicy.js)
@azure/cosmos-sign (imported by dist-esm/auth.js)
universal-user-agent (imported by dist-esm/common/platform.js)
uuid/v4 (imported by dist-esm/client/Item/Items.js)
binary-search-bounds (imported by dist-esm/queryExecutionContext/parallelQueryExecutionContextBase.js, dist-esm/routing/inMemoryCollectionRoutingMap.js)
priorityqueuejs (imported by dist-esm/queryExecutionContext/parallelQueryExecutionContextBase.js)
semaphore (imported by dist-esm/queryExecutionContext/parallelQueryExecutionContextBase.js)
node-abort-controller (imported by dist-esm/request/RequestHandler.js)
node-fetch (imported by dist-esm/request/RequestHandler.js)
atob (imported by dist-esm/session/sessionContainer.js)
crypto-hash (imported by dist-esm/queryExecutionContext/EndpointComponent/OrderedDistinctEndpointComponent.js, dist-esm/queryExecutionContext/EndpointComponent/UnorderedDistinctEndpointComponent.js)
fast-json-stable-stringify (imported by dist-esm/queryExecutionContext/EndpointComponent/OrderedDistinctEndpointComponent.js, dist-esm/queryExecutionContext/EndpointComponent/UnorderedDistinctEndpointComponent.js)
(!) Missing global variable names
Use output.globals to specify browser global variable names corresponding to external modules
universal-user-agent (guessing 'userAgent')
tslib (guessing 'tslib')
@azure/cosmos-sign (guessing 'cosmosSign')
binary-search-bounds (guessing 'bs')
priorityqueuejs (guessing 'PriorityQueue')
semaphore (guessing 'semaphore')
crypto-hash (guessing 'cryptoHash')
fast-json-stable-stringify (guessing 'stableStringify')
uuid/v4 (guessing 'uuid')
node-abort-controller (guessing 'AbortController')
node-fetch (guessing 'fetch')
atob (guessing 'atob')
(!) Circular dependency: dist-esm/queryExecutionContext/index.js -> dist-esm/queryExecutionContext/headerUtils.js -> dist-esm/queryMetrics/index.js -> dist-esm/queryMetrics/clientSideMetrics.js -> dist-esm/queryExecutionContext/index.js
(!) Circular dependency: dist-esm/index.js -> dist-esm/CosmosClient.js -> dist-esm/client/Database/index.js -> dist-esm/client/Database/Database.js -> dist-esm/client/Container/index.js -> dist-esm/client/Container/Container.js -> dist-esm/client/Script/Scripts.js -> dist-esm/index.js
(!) Circular dependency: dist-esm/request/RequestHandler.js -> dist-esm/retry/retryUtility.js -> dist-esm/request/RequestHandler.js
created dist/index.js in ?s
@azure/service-bus (? seconds)
Warning: You have changed the public API signature for this project. Updating review/service-bus.api.md
================================
BLOCKED (8)
================================
@azure/identity
Expand Down Expand Up @@ -101,4 +176,6 @@ XX of XX: [@azure/identity] blocked by [@azure/core-http]!
XX of XX: [@azure/core-amqp] blocked by [@azure/core-http]!
XX of XX: [@azure/event-hubs] blocked by [@azure/core-http]!
XX of XX: [@azure/template] blocked by [@azure/core-http]!
XX of XX: [@azure/cosmos] completed with warnings in ? seconds
XX of XX: [@azure/service-bus] completed with warnings in ? seconds
[@azure/core-http] Returned error code: 1
5 changes: 2 additions & 3 deletions tests/baselines/reference/docker/office-ui-fabric.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ Standard output:
@uifabric/merge-styles: Webpack version: 4.29.5
@uifabric/merge-styles: PASS src/styleToClassName.test.ts
@uifabric/merge-styles: PASS src/mergeStyleSets.test.ts
@uifabric/merge-styles: PASS src/concatStyleSets.test.ts
@uifabric/merge-styles: PASS src/mergeStyles.test.ts
@uifabric/merge-styles: PASS src/concatStyleSets.test.ts
@uifabric/merge-styles: PASS src/transforms/rtlifyRules.test.ts
@uifabric/merge-styles: PASS src/transforms/prefixRules.test.ts
@uifabric/merge-styles: PASS src/transforms/provideUnits.test.ts
Expand Down Expand Up @@ -425,12 +425,11 @@ lerna info Executing command in 40 packages: "yarn run build --production --lint
@uifabric/foundation: [XX:XX:XX XM] x ------------------------------------
@uifabric/foundation: [XX:XX:XX XM] x Error: Command failed: /usr/local/bin/node /office-ui-fabric-react/node_modules/jest/bin/jest.js --config /office-ui-fabric-react/packages/foundation/jest.config.js --passWithNoTests --colors
@uifabric/foundation: at ChildProcess.<anonymous> (/office-ui-fabric-react/node_modules/just-scripts-utils/lib/exec.js:70:31)
@uifabric/foundation: at ChildProcess.emit (events.js:203:13)
@uifabric/foundation: at ChildProcess.emit (events.js:209:13)
@uifabric/foundation: at ChildProcess.EventEmitter.emit (domain.js:499:23)
@uifabric/foundation: at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)
@uifabric/foundation: [XX:XX:XX XM] x ------------------------------------
@uifabric/foundation: [XX:XX:XX XM] x Error previously detected. See above for error messages.
@uifabric/foundation: [XX:XX:XX XM] x Other tasks that did not complete: [webpack]
@uifabric/foundation: error Command failed with exit code 1.
lerna ERR! yarn run build --production --lint exited 1 in '@uifabric/foundation'
lerna WARN complete Waiting for 1 child process to exit. CTRL-C to exit immediately.
13 changes: 13 additions & 0 deletions tests/baselines/reference/user/TypeScript-Node-Starter.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
Exit Code: 1
Standard output:
src/config/passport.ts(136,25): error TS2339: Property 'tokens' does not exist on type 'User'.
src/controllers/api.ts(22,28): error TS2339: Property 'tokens' does not exist on type 'User'.
src/controllers/api.ts(24,27): error TS2339: Property 'facebook' does not exist on type 'User'.
src/controllers/user.ts(145,28): error TS2339: Property 'id' does not exist on type 'User'.
src/controllers/user.ts(181,28): error TS2339: Property 'id' does not exist on type 'User'.
src/controllers/user.ts(197,33): error TS2339: Property 'id' does not exist on type 'User'.
src/controllers/user.ts(211,28): error TS2339: Property 'id' does not exist on type 'User'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sure this is @types/express' fault because it's fine pre-npm-install on both 3.5 and 3.7.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is a DT change that should be reverted.




Standard error:
2 changes: 0 additions & 2 deletions tests/baselines/reference/user/async.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,6 @@ node_modules/async/dist/async.js(1768,32): error TS2532: Object is possibly 'und
node_modules/async/dist/async.js(1768,38): error TS2532: Object is possibly 'undefined'.
node_modules/async/dist/async.js(1769,3): error TS2532: Object is possibly 'undefined'.
node_modules/async/dist/async.js(1773,35): error TS2532: Object is possibly 'undefined'.
node_modules/async/dist/async.js(1951,10): error TS1003: Identifier expected.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more lenient jsdoc parsing? (there is a stray trailing -: @param- {Object} [guard])

node_modules/async/dist/async.js(1951,10): error TS8024: JSDoc '@param' tag has name '', but there is no parameter with that name.
node_modules/async/dist/async.js(1990,16): error TS2554: Expected 3 arguments, but got 1.
node_modules/async/dist/async.js(2116,20): error TS2345: Argument of type 'Function | undefined' is not assignable to parameter of type 'number | undefined'.
Type 'Function' is not assignable to type 'number'.
Expand Down
1 change: 0 additions & 1 deletion tests/baselines/reference/user/bluebird.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,6 @@ node_modules/bluebird/js/release/using.js(78,20): error TS2339: Property 'doDisp
node_modules/bluebird/js/release/using.js(97,23): error TS2339: Property 'data' does not exist on type 'FunctionDisposer'.
node_modules/bluebird/js/release/using.js(131,72): error TS2339: Property 'classString' does not exist on type 'typeof ret'.
node_modules/bluebird/js/release/using.js(223,15): error TS2350: Only a void function can be called with the 'new' keyword.
node_modules/bluebird/js/release/util.js(200,32): error TS2339: Property 'foo' does not exist on type 'FakeConstructor'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prototype now has type any, which means that all property accesses are allowed now.

node_modules/bluebird/js/release/util.js(279,45): error TS2345: Argument of type 'PropertyDescriptor | { value: any; } | undefined' is not assignable to parameter of type 'PropertyDescriptor & ThisType<any>'.
Type 'undefined' is not assignable to type 'PropertyDescriptor & ThisType<any>'.
Type 'undefined' is not assignable to type 'PropertyDescriptor'.
Expand Down
Loading