-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Fixed issue for navbar when having multi-line string literals #32672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the test please
Fixes #32650 |
Tests added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable.
@@ -7,6 +7,10 @@ | |||
////} | |||
////declare module "MultilineMadness" {} | |||
//// | |||
////declare module "Multiline\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good. Just for future if you could number each Madness so result shows exactly which one is turned into which one would be great. Thank you.
That is would prefer this instead of current test
////declare module "Multiline\r\nMadness1" {
////}
////
////declare module "Multiline\
////Madness2" {
////}
////declare module "MultilineMadness3" {}
////
////declare module "Multiline\
////Madness4" {
////}
////
Truncate the a multi-line string literal to only the first line. Fixes on editors when there's an string literal as a parameter.
Example:
Visual Studio Error:

Fix:
