Fixed auto completion after a < token to return types not values. #32382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been on my personal list of annoyances for quite some time—I’m incredibly excited to test this out! |
diguifi
reviewed
Jul 15, 2019
| @@ -20,7 +20,10 @@ | |||
| ////new callAndConstruct<callAndConstruct</*callAndConstruct*/ | |||
|
|
|||
| for (const marker of test.markers()) { | |||
| if (marker.data && marker.data.valueOnly) { | |||
| if (marker.data && marker.data.typeOnly) { | |||
| verify.completions({ marker, includes: "T", excludes: "x" }); | |||
There was a problem hiding this comment.
Sorry for the noob question: does "T" and "x" stand for "Type" and "Value" respectively? I'm trying to understand a little bit of the code by checking some PR's (yours is pretty cool!)
There was a problem hiding this comment.
@diguifi They do not intrinsically stand for type and value. In this test they are used as stand-ins for type and value, but only because they are defined as such above:
////const x = 0;
////type T = number;
sheetalkamat
approved these changes
Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29769
Right now immediately after the
<token the suggestions do not include types. This PR changesisContextTokenTypeLocationto recognize that if the<token is encountered inside aTypeReference, types should be suggested.Interestingly there is a test that specifically tested that values are included in the suggestions for a type reference. I can't think of a case where this would be valid. This change removes values from completions here. I would say this is an improvement but I am unsure what the original intent was.