Skip to content

Update misspelling 'identifer' to 'identifier' #30894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 12, 2019
Merged

Update misspelling 'identifer' to 'identifier' #30894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e70405
fix typo - identifer to identifier
postama Apr 12, 2019
33e320d
fix typo - identifer to identifier
postama Apr 12, 2019
7bec113
Merge branch 'master' of github.com:postama/TypeScript
postama Apr 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/tsserver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33624,7 +33624,7 @@ var ts;
return type;
}
// A reserved member name starts with two underscores, but the third character cannot be an underscore
// or the @ symbol. A third underscore indicates an escaped form of an identifer that started
// or the @ symbol. A third underscore indicates an escaped form of an identifier that started
// with at least two underscores. The @ character indicates that the name is denoted by a well known ES
// Symbol instance.
function isReservedMemberName(name) {
Expand Down Expand Up @@ -99911,9 +99911,9 @@ var ts;
|| ts.isKnownSymbol(symbol)) {
return undefined;
}
var validIdentiferResult = { name: name, needsConvertPropertyAccess: false };
var validIdentifierResult = { name: name, needsConvertPropertyAccess: false };
if (ts.isIdentifierText(name, target))
return validIdentiferResult;
return validIdentifierResult;
switch (kind) {
case 3 /* MemberLike */:
return undefined;
Expand All @@ -99926,7 +99926,7 @@ var ts;
return name.charCodeAt(0) === 32 /* space */ ? undefined : { name: name, needsConvertPropertyAccess: true };
case 5 /* None */:
case 4 /* String */:
return validIdentiferResult;
return validIdentifierResult;
default:
ts.Debug.assertNever(kind);
}
Expand Down
8 changes: 4 additions & 4 deletions lib/tsserverlibrary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33623,7 +33623,7 @@ var ts;
return type;
}
// A reserved member name starts with two underscores, but the third character cannot be an underscore
// or the @ symbol. A third underscore indicates an escaped form of an identifer that started
// or the @ symbol. A third underscore indicates an escaped form of an identifier that started
// with at least two underscores. The @ character indicates that the name is denoted by a well known ES
// Symbol instance.
function isReservedMemberName(name) {
Expand Down Expand Up @@ -100250,9 +100250,9 @@ var ts;
|| ts.isKnownSymbol(symbol)) {
return undefined;
}
var validIdentiferResult = { name: name, needsConvertPropertyAccess: false };
var validIdentifierResult = { name: name, needsConvertPropertyAccess: false };
if (ts.isIdentifierText(name, target))
return validIdentiferResult;
return validIdentifierResult;
switch (kind) {
case 3 /* MemberLike */:
return undefined;
Expand All @@ -100265,7 +100265,7 @@ var ts;
return name.charCodeAt(0) === 32 /* space */ ? undefined : { name: name, needsConvertPropertyAccess: true };
case 5 /* None */:
case 4 /* String */:
return validIdentiferResult;
return validIdentifierResult;
default:
ts.Debug.assertNever(kind);
}
Expand Down
8 changes: 4 additions & 4 deletions lib/typescript.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33614,7 +33614,7 @@ var ts;
return type;
}
// A reserved member name starts with two underscores, but the third character cannot be an underscore
// or the @ symbol. A third underscore indicates an escaped form of an identifer that started
// or the @ symbol. A third underscore indicates an escaped form of an identifier that started
// with at least two underscores. The @ character indicates that the name is denoted by a well known ES
// Symbol instance.
function isReservedMemberName(name) {
Expand Down Expand Up @@ -100241,9 +100241,9 @@ var ts;
|| ts.isKnownSymbol(symbol)) {
return undefined;
}
var validIdentiferResult = { name: name, needsConvertPropertyAccess: false };
var validIdentifierResult = { name: name, needsConvertPropertyAccess: false };
if (ts.isIdentifierText(name, target))
return validIdentiferResult;
return validIdentifierResult;
switch (kind) {
case 3 /* MemberLike */:
return undefined;
Expand All @@ -100256,7 +100256,7 @@ var ts;
return name.charCodeAt(0) === 32 /* space */ ? undefined : { name: name, needsConvertPropertyAccess: true };
case 5 /* None */:
case 4 /* String */:
return validIdentiferResult;
return validIdentifierResult;
default:
ts.Debug.assertNever(kind);
}
Expand Down
8 changes: 4 additions & 4 deletions lib/typescriptServices.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33614,7 +33614,7 @@ var ts;
return type;
}
// A reserved member name starts with two underscores, but the third character cannot be an underscore
// or the @ symbol. A third underscore indicates an escaped form of an identifer that started
// or the @ symbol. A third underscore indicates an escaped form of an identifier that started
// with at least two underscores. The @ character indicates that the name is denoted by a well known ES
// Symbol instance.
function isReservedMemberName(name) {
Expand Down Expand Up @@ -100241,9 +100241,9 @@ var ts;
|| ts.isKnownSymbol(symbol)) {
return undefined;
}
var validIdentiferResult = { name: name, needsConvertPropertyAccess: false };
var validIdentifierResult = { name: name, needsConvertPropertyAccess: false };
if (ts.isIdentifierText(name, target))
return validIdentiferResult;
return validIdentifierResult;
switch (kind) {
case 3 /* MemberLike */:
return undefined;
Expand All @@ -100256,7 +100256,7 @@ var ts;
return name.charCodeAt(0) === 32 /* space */ ? undefined : { name: name, needsConvertPropertyAccess: true };
case 5 /* None */:
case 4 /* String */:
return validIdentiferResult;
return validIdentifierResult;
default:
ts.Debug.assertNever(kind);
}
Expand Down
2 changes: 1 addition & 1 deletion lib/typingsInstaller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33615,7 +33615,7 @@ var ts;
return type;
}
// A reserved member name starts with two underscores, but the third character cannot be an underscore
// or the @ symbol. A third underscore indicates an escaped form of an identifer that started
// or the @ symbol. A third underscore indicates an escaped form of an identifier that started
// with at least two underscores. The @ character indicates that the name is denoted by a well known ES
// Symbol instance.
function isReservedMemberName(name) {
Expand Down
2 changes: 1 addition & 1 deletion src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2836,7 +2836,7 @@ namespace ts {
}

// A reserved member name starts with two underscores, but the third character cannot be an underscore
// or the @ symbol. A third underscore indicates an escaped form of an identifer that started
// or the @ symbol. A third underscore indicates an escaped form of an identifier that started
// with at least two underscores. The @ character indicates that the name is denoted by a well known ES
// Symbol instance.
function isReservedMemberName(name: __String) {
Expand Down
6 changes: 3 additions & 3 deletions src/services/completions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1912,8 +1912,8 @@ namespace ts.Completions {
return undefined;
}

const validIdentiferResult: CompletionEntryDisplayNameForSymbol = { name, needsConvertPropertyAccess: false };
if (isIdentifierText(name, target)) return validIdentiferResult;
const validIdentifierResult: CompletionEntryDisplayNameForSymbol = { name, needsConvertPropertyAccess: false };
if (isIdentifierText(name, target)) return validIdentifierResult;
switch (kind) {
case CompletionKind.MemberLike:
return undefined;
Expand All @@ -1926,7 +1926,7 @@ namespace ts.Completions {
return name.charCodeAt(0) === CharacterCodes.space ? undefined : { name, needsConvertPropertyAccess: true };
case CompletionKind.None:
case CompletionKind.String:
return validIdentiferResult;
return validIdentifierResult;
default:
Debug.assertNever(kind);
}
Expand Down
16 changes: 8 additions & 8 deletions tests/baselines/reference/genericClassesRedeclaration.errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
tests/cases/compiler/genericClassesRedeclaration.ts(16,11): error TS2300: Duplicate identifier 'StringHashTable'.
tests/cases/compiler/genericClassesRedeclaration.ts(29,11): error TS2300: Duplicate identifier 'IdentiferNameHashTable'.
tests/cases/compiler/genericClassesRedeclaration.ts(29,11): error TS2300: Duplicate identifier 'IdentifierNameHashTable'.
tests/cases/compiler/genericClassesRedeclaration.ts(42,9): error TS2374: Duplicate string index signature.
tests/cases/compiler/genericClassesRedeclaration.ts(55,11): error TS2300: Duplicate identifier 'StringHashTable'.
tests/cases/compiler/genericClassesRedeclaration.ts(68,11): error TS2300: Duplicate identifier 'IdentiferNameHashTable'.
tests/cases/compiler/genericClassesRedeclaration.ts(68,11): error TS2300: Duplicate identifier 'IdentifierNameHashTable'.


==== tests/cases/compiler/genericClassesRedeclaration.ts (5 errors) ====
Expand Down Expand Up @@ -36,9 +36,9 @@ tests/cases/compiler/genericClassesRedeclaration.ts(68,11): error TS2300: Duplic
public lookup(key: string): T;
public remove(key: string): void;
}
class IdentiferNameHashTable<T> extends StringHashTable<T> {
~~~~~~~~~~~~~~~~~~~~~~
!!! error TS2300: Duplicate identifier 'IdentiferNameHashTable'.
class IdentifierNameHashTable<T> extends StringHashTable<T> {
~~~~~~~~~~~~~~~~~~~~~~~
!!! error TS2300: Duplicate identifier 'IdentifierNameHashTable'.
public getAllKeys(): string[];
public add(key: string, data: T): boolean;
public addOrUpdate(key: string, data: T): boolean;
Expand Down Expand Up @@ -81,9 +81,9 @@ tests/cases/compiler/genericClassesRedeclaration.ts(68,11): error TS2300: Duplic
public lookup(key: string): T;
public remove(key: string): void;
}
class IdentiferNameHashTable<T> extends StringHashTable<T> {
~~~~~~~~~~~~~~~~~~~~~~
!!! error TS2300: Duplicate identifier 'IdentiferNameHashTable'.
class IdentifierNameHashTable<T> extends StringHashTable<T> {
~~~~~~~~~~~~~~~~~~~~~~~
!!! error TS2300: Duplicate identifier 'IdentifierNameHashTable'.
public getAllKeys(): string[];
public add(key: string, data: T): boolean;
public addOrUpdate(key: string, data: T): boolean;
Expand Down
4 changes: 2 additions & 2 deletions tests/baselines/reference/genericClassesRedeclaration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ declare module TypeScript {
public lookup(key: string): T;
public remove(key: string): void;
}
class IdentiferNameHashTable<T> extends StringHashTable<T> {
class IdentifierNameHashTable<T> extends StringHashTable<T> {
public getAllKeys(): string[];
public add(key: string, data: T): boolean;
public addOrUpdate(key: string, data: T): boolean;
Expand Down Expand Up @@ -66,7 +66,7 @@ declare module TypeScript {
public lookup(key: string): T;
public remove(key: string): void;
}
class IdentiferNameHashTable<T> extends StringHashTable<T> {
class IdentifierNameHashTable<T> extends StringHashTable<T> {
public getAllKeys(): string[];
public add(key: string, data: T): boolean;
public addOrUpdate(key: string, data: T): boolean;
Expand Down
Loading