Handle imports and exports in 'convert parameters to destructured object' #30475
Conversation
…nt access expressions
…osoft/TypeScript into namedParametersImportExport
|
|
||
| // @Filename: f.ts | ||
| ////function foo(/*a*/a: string, b: string/*b*/) { } | ||
| ////export = foo; |
There was a problem hiding this comment.
I think you can also export = function(.... Is that case supported?
There was a problem hiding this comment.
("No" is a reasonable answer - I mostly want to know if the case was considered.)
In reply to: 269694751 [](ancestors = 269694751)
There was a problem hiding this comment.
It's not supported, but I didn't considered it, that's a good point. The refactoring is not offered in this case because this is a function expression (or an arrow function) that is in an export assignment and we only offer it if the function expression is assigned to a const variable.
There was a problem hiding this comment.
i've briefly thought about supporting this case and it would require some changes to be able to call findAllReferences, so i think it's better to consider supporting this on another PR later.
There was only one test that I could find, which was checking that the refactoring was not available on a constructor of a default class without a name, and it should be available now. However the test was passing after the changes in this PR because there was an extra slash, so there were five slashes. |
Contributes to #30113.
This PR allows the 'convert parameters to destructured object' to apply changes when the function being refactored is exported or imported with TS-recognized syntax. Previously the refactor would not apply any changes when it found an import or export reference to the function being refactored.
In addition, we can now refactor a function declaration that doesn't have a name but is a default export, and a constructor of a class declaration that doesn't have a name but is a default export.