Skip to content

Remove circularity fallback deferral in getConditionalType #30470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

weswigham
Copy link
Member

Per commentary in #30443, this reverts the code change in #30375, but keeps the new test.

@weswigham weswigham requested a review from ahejlsberg March 18, 2019 21:26
@weswigham
Copy link
Member Author

@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 18, 2019

Heya @weswigham, I've started to run the Definitely Typed test suite on this PR at c6df72c. You can monitor the build here. It should now contribute to this PR's status checks.

@weswigham
Copy link
Member Author

DT failure is in ramda:

Error in ramda
Error: /home/vsts/work/1/s/dtslint-runner/DefinitelyTyped/types/ramda/ramda-tests.ts:970:26
ERROR: 970:26  expect  TypeScript@local compile error: 
Argument of type '<T>(obj: Record<"id", T>) => T' is not assignable to parameter of type '(a: Record<"id", T>) => string'.
  Type 'T' is not assignable to type 'string'.

    at /home/vsts/work/1/s/dtslint-runner/node_modules/dtslint/bin/index.js:210:19
    at Generator.next (<anonymous>)
    at fulfilled (/home/vsts/work/1/s/dtslint-runner/node_modules/dtslint/bin/index.js:5:58)
The following packages had errors: ramda
FAILED

It's the const a2 = R.indexBy(R.prop("id"))(list); - which looks like the last error left in ramda after today's fix (which I think the author already said might be due to some incorrect types in ramda, rather than a fault on our part - I haven't looked into this one, though).

In any case, not the fault of reverting this, so I'm going to merge this.

@weswigham weswigham merged commit 9e28a81 into microsoft:master Mar 18, 2019
@weswigham weswigham deleted the remove-conditional-type-reentrancy-check branch March 18, 2019 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants