Use shorthand property assignment in convert parameters to object #30468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 14, 2019 09:58
| //// */ | ||
| ////export function /*c*/getBoolFromAttribute/*d*/( | ||
| //// /*e*//** inline JSDoc *//*f*/ attr: string | string[], | ||
| //// def: boolean = false): boolean { } |
There was a problem hiding this comment.
Does the refactoring here change jsDoc as well? Why not verify new content as well apart from verifying refactor available?
There was a problem hiding this comment.
So far it does not change JSDoc, that's a future work item.
sheetalkamat
approved these changes
Mar 18, 2019
sandersn
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way the argument object is created by 'convert parameters to destructured object' when refactoring a function call. When creating a property assignment of the argument object we now use shorthand property assignments when possible.
This PR also adjusts the refactoring so that it is not offered on a function's JSDoc comment.