Skip to content

Filter ts only keywords from js file completion #30414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 20, 2019
Merged

Filter ts only keywords from js file completion #30414

merged 3 commits into from
Mar 20, 2019

Conversation

sheetalkamat
Copy link
Member

Fixes #29212

weswigham
weswigham reviewed Mar 15, 2019
View reviewed changes
@sheetalkamat sheetalkamat requested a review from weswigham March 15, 2019 21:16
ajafff
ajafff reviewed Mar 15, 2019
View reviewed changes
@sheetalkamat
Copy link
Member Author

Ping! This is 3.4 bug. Thanks

weswigham
weswigham reviewed Mar 20, 2019
View reviewed changes
@sheetalkamat sheetalkamat merged commit 800f7a3 into master Mar 20, 2019
@sheetalkamat sheetalkamat deleted the jsSyntaxCompletions branch March 20, 2019 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajafff ajafff ajafff left review comments

@weswigham weswigham weswigham approved these changes

@sandersn sandersn Awaiting requested review from sandersn

@rbuckton rbuckton Awaiting requested review from rbuckton

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sheetalkamat @weswigham @ajafff