Fixes #29524, a merged UMD-global #30403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This kind of merged symbol causes crashes in two places because it's marked BlockScoped, which makes us assume that it must be something that is inside a SourceFile. However, block-scoped checks don't make sense for this kind of symbol, so I exclude them by looking at the kind of the valueDeclaration, as @mprobst suggested in the original bug.
| declare global { | ||
| export const THREE: typeof _three; | ||
| ~~~~~ | ||
| !!! error TS2403: Subsequent variable declarations must have the same type. Variable 'THREE' must be of type 'typeof import("tests/cases/compiler/global")', but here has type 'typeof import("tests/cases/compiler/three")'. |
There was a problem hiding this comment.
Is this correct error? Seems very confusing
There was a problem hiding this comment.
It is - tests/cases/compiler/global is the file with the export as namespace, while three is the export namespace THREE file.
sandersn
commented
Mar 14, 2019
| declare global { | ||
| export const THREE: typeof _three; | ||
| ~~~~~ | ||
| !!! error TS2403: Subsequent variable declarations must have the same type. Variable 'THREE' must be of type 'typeof import("tests/cases/compiler/global")', but here has type 'typeof import("tests/cases/compiler/three")'. |
There was a problem hiding this comment.
Well, this error is not specific to export as namespace, making it more confusing. But it is correct. The two declarations of THREE are
export as namespace THREE, which has the type of the containing module,typeof import("./global").export const THREE, which is in the global namespace. Its declared type istypeof _three, which is the type of the imported module './three',typeof import("./three")
These are not the same type, although they might be assignable to each other.
RyanCavanaugh
approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This kind of merged symbol causes crashes in two places because it's
marked BlockScoped, which makes us assume that it must be something that
is inside a SourceFile. However, block-scoped checks don't make sense
for this kind of symbol, so I exclude them by looking at the kind of
the valueDeclaration, as @mprobst suggested in the original bug.
Fixes #29524