Skip to content

add jsx factory and hold text in jsxtext node #29439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 11, 2019
Merged

add jsx factory and hold text in jsxtext node #29439

merged 3 commits into from
Mar 11, 2019

Conversation

Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Jan 16, 2019

Fixes #29425

ajafff
ajafff reviewed Jan 16, 2019
View reviewed changes
@Kingwl
Copy link
Contributor Author

Kingwl commented Jan 19, 2019

🆙

@Kingwl Kingwl mentioned this pull request Jan 23, 2019
Closed
@weswigham weswigham merged commit b97b1a8 into microsoft:master Mar 11, 2019
@Kingwl Kingwl deleted the jsx_text_node branch March 12, 2019 07:38
@dsherret
Copy link
Contributor

Update https://github.com/Microsoft/TypeScript/wiki/API-Breaking-Changes ?

@weswigham
Copy link
Member

weswigham commented Mar 30, 2019 •
edited
Loading

Cc @DanielRosenwasser

@Kingwl
Copy link
Contributor Author

Kingwl commented Mar 31, 2019

the only things has been break is the containsOnlyWhiteSpaces😅

@dsherret
Copy link
Contributor

dsherret commented Mar 31, 2019 •
edited
Loading

That’s ok! Just making sure it's documented. Thanks for adding the factories 🙂

This was referenced May 9, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham left review comments

@ajafff ajafff ajafff left review comments

Assignees

@weswigham weswigham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kingwl @dsherret @weswigham @ajafff