add transformer for emit add property to default export #29242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
reviewed
Jan 3, 2019
|
Kingwl
force-pushed
the
attach_property_to_default_export
branch
from
0a10e12 to
ae18c9d
Compare
Kingwl
force-pushed
the
attach_property_to_default_export
branch
from
ae18c9d to
d8aa462
Compare
|
⬆️ |
weswigham
requested changes
Mar 12, 2019
src/compiler/types.ts
Outdated
| @@ -3508,7 +3508,8 @@ namespace ts { | |||
| | ModuleDeclaration | |||
| | TypeAliasDeclaration | |||
| | InterfaceDeclaration | |||
| | EnumDeclaration; | |||
| | EnumDeclaration | |||
| | ExportAssignment; | |||
There was a problem hiding this comment.
Why was this added here (and the empty case in transformTopLevelDeclaration)? Without it being added to the isLateVisibilityPaintedStatement, it will still fail to be printed late.
Kingwl
force-pushed
the
attach_property_to_default_export
branch
from
6f61fbc to
e8b6615
Compare
|
🆙 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29206