Only provide suggestion for outermost async fix #29214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
requested changes
Dec 31, 2018
| @@ -167,16 +174,24 @@ namespace ts { | |||
| } | |||
|
|
|||
| // should be kept up to date with getTransformationBody in convertToAsyncFunction.ts | |||
| function isFixablePromiseArgument(arg: Expression): boolean { | |||
| function isFixablePromiseArgument(arg: Expression, checker: TypeChecker): boolean { | |||
There was a problem hiding this comment.
is this only called on nested functions? Or is visitedNestedConvertibleFunctions a misnomer and should just be visitedConvertibleFunctions?
There was a problem hiding this comment.
Yes, it's only called on arguments of promise handlers (e.g., then or catch).
sandersn
approved these changes
Jan 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27488.
Currently, if
getCombinedCodeFixis triggered in a file with nested functions that can be converted to async functions, the call fails since our text change mechanism cannot handle overlapping changes.This PR makes it so that only the outermost suggestion diagnostic for nested convertible functions is provided so that such a conflict is not encountered. Note that if
getCodeActionsis triggered at the location of an inner convertible function, it will return the action, since we do not inspect the surrounding context of a given function.This PR also removes unnecessary trailing spaces from several tests.