Skip to content

🤖 User test baselines have changed #28524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

🤖 User test baselines have changed #28524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tests/baselines/reference/user/TypeScript-React-Starter.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
Exit Code: 1
Standard output:
src/App.tsx(2,8): error TS2307: Cannot find module './App.css'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!?!? Did something in this project's dependency hierarchy change to no longer include a css blanket module declaration? cc @DanielRosenwasser

Copy link
Member

@weswigham weswigham Nov 14, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhhhhhhhhhhhhhhhhhhhhhh, I know what it is - we don't have a *.css module reference in the starter and never have. And for some reason, we've never validated the paths on ImportDeclarations with no clauses (because we only do that during export resolution and if you request no members, we do no export resolution). In 7a71887, getAlternativeContainingModules attempts a lookup of all imports in a file (including ones we don't look at exports for) to try to find aliases of a symbol for printing a better name for it. This causes us to actually check the validity of the import and learn that in fact it is not valid.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanielRosenwasser didn't that we don't check these kinds of imports come up recently? Do we want to formally fix the behavior and check their validity (like this, but ideally more explicitly), or should I suppress any errors from resolveExternalModuleName during getAlternativeContainingModules?

src/components/Hello.tsx(2,8): error TS2307: Cannot find module './Hello.css'.



Standard error:
2 changes: 1 addition & 1 deletion tests/baselines/reference/user/assert.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Exit Code: 1
Standard output:
node_modules/assert/assert.js(124,8): error TS2540: Cannot assign to 'name' because it is a constant or a read-only property.
node_modules/assert/assert.js(124,8): error TS2540: Cannot assign to 'name' because it is a read-only property.
node_modules/assert/assert.js(125,8): error TS2339: Property 'actual' does not exist on type 'typeof ok'.
node_modules/assert/assert.js(126,8): error TS2339: Property 'expected' does not exist on type 'typeof ok'.
node_modules/assert/assert.js(127,8): error TS2339: Property 'operator' does not exist on type 'typeof ok'.
Expand Down
4 changes: 2 additions & 2 deletions tests/baselines/reference/user/chrome-devtools-frontend.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3286,7 +3286,7 @@ node_modules/chrome-devtools-frontend/front_end/bindings_test_runner/BindingsTes
node_modules/chrome-devtools-frontend/front_end/bindings_test_runner/BindingsTestRunner.js(59,9): error TS2403: Subsequent variable declarations must have the same type. Variable 'url' must be of type 'any', but here has type 'string'.
node_modules/chrome-devtools-frontend/front_end/bindings_test_runner/BindingsTestRunner.js(108,11): error TS2339: Property 'src' does not exist on type 'HTMLElement'.
node_modules/chrome-devtools-frontend/front_end/bindings_test_runner/IsolatedFilesystemTestRunner.js(103,8): error TS2339: Property '_fileSystem' does not exist on type 'typeof TestFileSystem'.
node_modules/chrome-devtools-frontend/front_end/bindings_test_runner/IsolatedFilesystemTestRunner.js(104,8): error TS2540: Cannot assign to 'name' because it is a constant or a read-only property.
node_modules/chrome-devtools-frontend/front_end/bindings_test_runner/IsolatedFilesystemTestRunner.js(104,8): error TS2540: Cannot assign to 'name' because it is a read-only property.
node_modules/chrome-devtools-frontend/front_end/bindings_test_runner/IsolatedFilesystemTestRunner.js(105,8): error TS2339: Property '_children' does not exist on type 'typeof TestFileSystem'.
node_modules/chrome-devtools-frontend/front_end/bindings_test_runner/IsolatedFilesystemTestRunner.js(106,8): error TS2339: Property '_childrenMap' does not exist on type 'typeof TestFileSystem'.
node_modules/chrome-devtools-frontend/front_end/bindings_test_runner/IsolatedFilesystemTestRunner.js(107,8): error TS2339: Property 'isDirectory' does not exist on type 'typeof TestFileSystem'.
Expand Down Expand Up @@ -5827,7 +5827,7 @@ node_modules/chrome-devtools-frontend/front_end/elements_test_runner/ElementsTes
node_modules/chrome-devtools-frontend/front_end/elements_test_runner/ElementsTestRunner.js(429,28): error TS2339: Property 'sprintf' does not exist on type 'StringConstructor'.
node_modules/chrome-devtools-frontend/front_end/elements_test_runner/ElementsTestRunner.js(490,15): error TS2339: Property 'runtime' does not exist on type 'Window'.
node_modules/chrome-devtools-frontend/front_end/elements_test_runner/ElementsTestRunner.js(549,33): error TS2339: Property 'elements' does not exist on type 'any[]'.
node_modules/chrome-devtools-frontend/front_end/elements_test_runner/ElementsTestRunner.js(735,11): error TS2540: Cannot assign to 'name' because it is a constant or a read-only property.
node_modules/chrome-devtools-frontend/front_end/elements_test_runner/ElementsTestRunner.js(735,11): error TS2588: Cannot assign to 'name' because it is a constant.
node_modules/chrome-devtools-frontend/front_end/elements_test_runner/ElementsTestRunner.js(1024,26): error TS2339: Property 'elements' does not exist on type 'any[]'.
node_modules/chrome-devtools-frontend/front_end/elements_test_runner/ElementsTestRunner.js(1048,13): error TS2339: Property 'elements' does not exist on type 'any[]'.
node_modules/chrome-devtools-frontend/front_end/elements_test_runner/ElementsTestRunner.js(1052,13): error TS2339: Property 'elements' does not exist on type 'any[]'.
Expand Down