-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Feature/28297 make error message at a constant or a read only property more specific #28313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DanielRosenwasser
merged 7 commits into
microsoft:master
from
a-tarasyuk:feature/28297-make-error-message-at--a-constant-or-a-read-only-property--more-specific
Nov 13, 2018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Nov 2, 2018
ghost
reviewed
Nov 2, 2018
7061101
to
66539b4
Compare
@Andy-MS Thanks. I've added requested changes. |
Ishaan28malik
approved these changes
Nov 5, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well Done...
ghost
approved these changes
Nov 5, 2018
@DanielRosenwasser please review (github reviewers section not working right now) |
… feature/28297-make-error-message-at--a-constant-or-a-read-only-property--more-specific
… feature/28297-make-error-message-at--a-constant-or-a-read-only-property--more-specific
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28297