Avoid elaborating on generic indexes #28294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| !!! error TS2345: Type 'T' is not assignable to type 'S["a"] & T'. | ||
| !!! error TS2345: Type 'Foo' is not assignable to type 'S["a"] & T'. | ||
| !!! error TS2345: Type 'Foo' is not assignable to type 'S["a"]'. | ||
| !!! error TS2345: Type 'T' is not assignable to type 'S["a"]'. |
There was a problem hiding this comment.
Seems a little weird to have this extra line, and it's supposedly because intersections always have an extra this-type? Seems like a leak of impl. details
There was a problem hiding this comment.
Should open another issue for this; this was the prior message.
| const targetPropType = getIndexedAccessType(target, nameType, /*accessNode*/ undefined, errorType); | ||
| if (targetPropType === errorType || targetPropType.flags & TypeFlags.IndexedAccess) continue; // Don't elaborate on indexes on generic variables |
There was a problem hiding this comment.
Why do you have to look at the errorType?
There was a problem hiding this comment.
errorType is what getIndexedAccessType returns when the property doesn't exist; ergo we do not want to dive into it. I just moved up the check from a line or two below.
sandersn
approved these changes
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25971