Avoid stack overflow in completions #28286
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In symbolCanBeReferfencedAtTypeLocation, 3.1.3 has a stack overflow in the recursive case that checks exportedSymbols. I believe that the cause is a commonjs module with both export assignment and export property assignments via an alias [1], but I haven't been able to repro the crash. Nevertheless, I think the correct fix is just to not recur in the case that an exported symbol is identical to its containing module. ```js // @filename: module.js exports.version = 'hi' function alias() { } module.exports = alias // @filename: use.js var m = require('./module') m.al/**/ ``` I expected the overflow to happen when requesting completions at `/**/` but it didn't.
sheetalkamat
reviewed
Nov 1, 2018
| @@ -1142,7 +1142,7 @@ namespace ts.Completions { | |||
| const exportedSymbols = typeChecker.getExportsOfModule(symbol); | |||
| // If the exported symbols contains type, | |||
| // symbol can be referenced at locations where type is allowed | |||
| return exportedSymbols.some(symbolCanBeReferencedAtTypeLocation); | |||
| return exportedSymbols.some(ex => ex !== symbol && symbolCanBeReferencedAtTypeLocation(ex)); | |||
There was a problem hiding this comment.
Could the repro be exportedSymbol => some other symbol => exportedSymbol or some such recursion?
There was a problem hiding this comment.
Yes, although for the pattern I referenced above, from #28133, has the cycle directly between two symbols.
ghost
mentioned this pull request
|
The reason that doesn't reproduce the issue is it's not recursive, and isn't tested at a type location so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In symbolCanBeReferfencedAtTypeLocation, telemetry reports that 3.1.3 has a stack overflow in the recursive case that checks exportedSymbols. I believe that the cause is a commonjs module with both export assignment and export property assignments via an alias [1], but I haven't been able to repro the crash since telemetry only reports a stack. Nevertheless, I think the correct fix is just to not recur in the case that an exported symbol is identical to its containing module.
I expected the overflow to happen when requesting completions at
/**/but it didn't.Fixes #27872