Fix combineTypeMappers to use instantiateType #2824
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1424.
When you have a chain of instantiated generics, like this:
Eventually T1 has to be replaced with string in Type1. So to do that we combine / compose the two type mappers that we already have. The result is a type mapper that replaces T1 with T2, and then immediately replaces the resulting T2 with string.
This worked when the output of the first mapper was a type parameter (in the above example T2). However, the first mapper can output an arbitrary type, and it might not be appropriate to immediately apply the second mapper (this was the problem in #1424). In general, it is necessary to treat the application of the second mapper as an instantiation, and not simply apply the second mapper.
Another way of saying this is that a mapper must take a TypeParameter as a parameter, even though it can output any Type.