When contextual type doesnt find property in unit type, use the index signature from unit type(fix the incorrectly used union type to get the signature) #27952

sheetalkamat · 2018-10-17T21:20:22Z

…om unit type(fix the incorrectly used union type to get the signature) Fixes #27949

weswigham

The CI failures look like lint changes, but seem unrelated? Know why? Did the better contextual typing somehow affect the types of the things being asserted in a positive way?

weswigham · 2018-10-17T21:53:06Z

Build failure seems unrelated; it's happening elsewhere. I'm guessing tslint updated or something?

When contextual type doesnt find property, use the index signature fr…

31f4053

…om unit type(fix the incorrectly used union type to get the signature) Fixes #27949

sheetalkamat requested a review from weswigham October 17, 2018 21:20

weswigham approved these changes Oct 17, 2018

View reviewed changes

sheetalkamat merged commit 7b9ae4d into master Oct 17, 2018

sheetalkamat deleted the contextualSignature branch October 17, 2018 21:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

When contextual type doesnt find property in unit type, use the index signature from unit type(fix the incorrectly used union type to get the signature) #27952

When contextual type doesnt find property in unit type, use the index signature from unit type(fix the incorrectly used union type to get the signature) #27952

sheetalkamat commented Oct 17, 2018

weswigham left a comment

weswigham commented Oct 17, 2018

When contextual type doesnt find property in unit type, use the index signature from unit type(fix the incorrectly used union type to get the signature) #27952

When contextual type doesnt find property in unit type, use the index signature from unit type(fix the incorrectly used union type to get the signature) #27952

Conversation

sheetalkamat commented Oct 17, 2018

weswigham left a comment

Choose a reason for hiding this comment

weswigham commented Oct 17, 2018