Skip to content

textChanges: Reuse some methods #27492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Oct 3, 2018
Merged

textChanges: Reuse some methods #27492

1 commit merged into from
Oct 3, 2018

Conversation

ghost
Copy link

@ghost ghost commented Oct 2, 2018

Made some methods call others that already implement their functionality.

@ghost ghost requested review from uniqueiniquity and amcasey October 2, 2018 00:51
amcasey
amcasey approved these changes Oct 3, 2018
View reviewed changes
Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@ghost ghost merged commit 16766b1 into master Oct 3, 2018
@ghost ghost deleted the textChanges_reuse branch October 3, 2018 00:34
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uniqueiniquity uniqueiniquity Awaiting requested review from uniqueiniquity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@amcasey