Fix issue of program not being reused when host implements getSourceFileByPath #27483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…getSourceFileByPath Test for #27207
sheetalkamat
requested review from
a user,
weswigham and
RyanCavanaugh
and removed request for
a user
ghost
approved these changes
Oct 1, 2018
| fileExists: fileName => files.has(fileName), | ||
| readFile: fileName => { | ||
| const file = files.get(fileName); | ||
| return file && file.text; | ||
| }, | ||
| }; | ||
| if (useGetSourceFileByPath) { |
There was a problem hiding this comment.
Might as well calculate filesByPath inside the if.
ghost
approved these changes
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was because redirect file didn't set
resolvedPathwhich then would pick from redirected file. So when getting source file, instead of getting if for undirected path, we would end up getting source file for redirected file and then comparing wrong files together.Fixes #27207