Skip to content

Don't complain about modules and outFile options when emitDeclarationOnly is set. #27447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/compiler/program.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2577,7 +2577,7 @@ namespace ts {
}

// Cannot specify module gen that isn't amd or system with --out
if (outFile) {
if (outFile && !options.emitDeclarationOnly) {
if (options.module && !(options.module === ModuleKind.AMD || options.module === ModuleKind.System)) {
createDiagnosticForOptionName(Diagnostics.Only_amd_and_system_modules_are_supported_alongside_0, options.out ? "out" : "outFile", "module");
}
Expand Down
2 changes: 1 addition & 1 deletion src/compiler/utilities.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3265,7 +3265,7 @@ namespace ts {
const isSourceFileFromExternalLibrary = (file: SourceFile) => host.isSourceFileFromExternalLibrary(file);
if (options.outFile || options.out) {
const moduleKind = getEmitModuleKind(options);
const moduleEmitEnabled = moduleKind === ModuleKind.AMD || moduleKind === ModuleKind.System;
const moduleEmitEnabled = options.emitDeclarationOnly || moduleKind === ModuleKind.AMD || moduleKind === ModuleKind.System;
// Can emit only sources that are not declaration file and are either non module code or module with --module or --target es6 specified
return filter(host.getSourceFiles(), sourceFile =>
(moduleEmitEnabled || !isExternalModule(sourceFile)) && sourceFileMayBeEmitted(sourceFile, options, isSourceFileFromExternalLibrary));
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
//// [tests/cases/compiler/outModuleConcatCommonjsDeclarationOnly.ts] ////

//// [a.ts]
export class A { }

//// [b.ts]
import {A} from "./ref/a";
export class B extends A { }



//// [all.d.ts]
declare module "ref/a" {
export class A {
}
}
declare module "b" {
import { A } from "ref/a";
export class B extends A {
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
=== tests/cases/compiler/ref/a.ts ===
export class A { }
>A : Symbol(A, Decl(a.ts, 0, 0))

=== tests/cases/compiler/b.ts ===
import {A} from "./ref/a";
>A : Symbol(A, Decl(b.ts, 0, 8))

export class B extends A { }
>B : Symbol(B, Decl(b.ts, 0, 26))
>A : Symbol(A, Decl(b.ts, 0, 8))

Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
=== tests/cases/compiler/ref/a.ts ===
export class A { }
>A : A

=== tests/cases/compiler/b.ts ===
import {A} from "./ref/a";
>A : typeof A

export class B extends A { }
>B : B
>A : A

Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
//// [tests/cases/compiler/outModuleConcatUnspecifiedModuleKindDeclarationOnly.ts] ////

//// [a.ts]
export class A { } // module

//// [b.ts]
var x = 0; // global



//// [out.d.ts]
declare module "a" {
export class A {
}
}
declare var x: number;
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
=== tests/cases/compiler/a.ts ===
export class A { } // module
>A : Symbol(A, Decl(a.ts, 0, 0))

=== tests/cases/compiler/b.ts ===
var x = 0; // global
>x : Symbol(x, Decl(b.ts, 0, 3))

Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
=== tests/cases/compiler/a.ts ===
export class A { } // module
>A : A

=== tests/cases/compiler/b.ts ===
var x = 0; // global
>x : number
>0 : 0

13 changes: 13 additions & 0 deletions tests/cases/compiler/outModuleConcatCommonjsDeclarationOnly.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
// @target: ES5
// @sourcemap: true
// @declaration: true
// @emitDeclarationOnly: true
// @module: commonjs
// @outFile: all.js

// @Filename: ref/a.ts
export class A { }

// @Filename: b.ts
import {A} from "./ref/a";
export class B extends A { }
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
// @target: ES5
// @outFile: out.js
// @declaration: true
// @emitDeclarationOnly: true

// @Filename: a.ts
export class A { } // module

// @Filename: b.ts
var x = 0; // global